Repository navigation
Add Dashlane password import - #256
Merged
Merged
Conversation
Dashlane gets its own source in the import dialog with export steps. The zip from Export to CSV is read as it is, 2FA from the newer otpUrl column is linked to its login, username2/username3 fill an empty username, the category becomes a tag, and the older desktop app's JSON export is read too. A .dash secure archive explains to export a CSV instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Dashlane is now a first-class source in Logins → Import.
credentials.csvis used, notes/IDs/payments in the zip are left out.otpUrlcolumn (and the olderotpSecret) is saved as a 2FA code and linked to its login.username2/username3fill an empty username, Dashlane'scategorybecomes a tag.AUTHENTIFIANT) is read too; other JSON files are refused with a clear message..dashsecure archive (encrypted) explains to use Export to CSV instead.How to test
bun test test/password-import.test.ts(31 pass, 3 new Dashlane tests), desktop typecheck clean.Screenshots
Dark: