Repo hardening: fix install instructions, dead imports, hygiene#1
Open
cognis-digital wants to merge 5 commits into
Open
Repo hardening: fix install instructions, dead imports, hygiene#1cognis-digital wants to merge 5 commits into
cognis-digital wants to merge 5 commits into
Conversation
- fix 2 broken `pip install` line(s) in README (package is not on PyPI; use the working git+https install) - remove 5 unused import(s) (ruff F401/F811)
9699f71 to
61b7e67
Compare
added 4 commits
June 13, 2026 03:47
…verview and install scripts The --format option was defined only on the top-level parser, so passing it after a subcommand (e.g. validate --format json) triggered an argparse error and caused two smoke tests to fail. Added --format to each subparser (validate, crosswalk, detect) so the flag works in the natural position users expect. Also adds a plain-language 'What is this?' section to the README and comprehensive cross-platform install scripts (install.sh / install.ps1).
- cli._load(): catch FileNotFoundError, UnicodeDecodeError, csv.Error, OSError on --table files; print a clear message to stderr and raise SystemExit(2) - cli._read_codes(): catch FileNotFoundError, UnicodeDecodeError, OSError on --input files; same clean-exit behaviour - cli.main(): wrap dispatch in try/except; re-raise SystemExit, handle KeyboardInterrupt gracefully, catch unexpected exceptions without traceback - Add import csv (needed for csv.Error guard) - Add _die() helper for callers that return 2 directly - tests/test_hardening.py: 7 new tests covering missing files (exit 2), invalid UTF-8 input and table files (exit 2), unknown --to target (exit 2), and comment-only input file (exit 2)
… mcp_server imports, add ruff config, and expand edge-case test coverage
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR applies a few small, mechanically-verified hardening fixes found by an automated audit of the Cognis suite:
pip installline(s) in README (package is not on PyPI; use the working git+https install)Each change is deterministic; all touched Python files were confirmed to still compile (
py_compile) before this PR was opened.