-
Notifications
You must be signed in to change notification settings - Fork 36
release v8.0.0a2
#2425
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release v8.0.0a2
#2425
Conversation
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. |
15b4c56 to
0fbae11
Compare
270ac38 to
e9439d4
Compare
e9439d4 to
a470c70
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## pysdk-release-v8-alpha-2 #2425 +/- ##
===========================================================
Coverage ? 64.77%
===========================================================
Files ? 462
Lines ? 47228
Branches ? 0
===========================================================
Hits ? 30593
Misses ? 16635
Partials ? 0
🚀 New features to boost your workflow:
|
0ec9dc8 to
f3af288
Compare
|
/gemini review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request prepares the v8.0.0a2 release. The most significant change is a major refactoring of the HTTP client layer to abstract away the underlying httpx library by introducing CogniteSDKResponse and CogniteHTTPStatusError. This is an excellent architectural improvement that will make the SDK more maintainable.
Other notable changes include a critical fix for blocking time.sleep in async code, improved error handling, and various refactorings for clarity and type safety. The changes are of high quality.
I have one comment regarding some redundant code.
Additionally, please note that the pull request title does not follow the Conventional Commit specification outlined in the repository's style guide (lines 168-181). For a release, a title like chore(release): release v8.0.0a2 would be more appropriate. Since this release contains breaking changes, it should also include a ! in the title, for example: chore(release)!: release v8.0.0a2 (style guide line 183).
f3af288 to
1981df1
Compare
|
We should also fix the |
|
Closing in favor of: #2435 |
https://cognitedata.atlassian.net/browse/DM-3372
Release v8 alpha 2
pysdk-release-v8-alpha-2)