Skip to content

Conversation

@haakonvt
Copy link
Contributor

@haakonvt haakonvt commented Dec 9, 2025

https://cognitedata.atlassian.net/browse/DM-3372

Release v8 alpha 2

  • Includes the latest from master (already on branch pysdk-release-v8-alpha-2)
  • Several fixes to not break imports nilly-willy
  • Moar?

@haakonvt haakonvt requested review from a team as code owners December 9, 2025 10:15
@gemini-code-assist
Copy link
Contributor

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

@haakonvt haakonvt force-pushed the v8-change-requests-to-httpx branch from 15b4c56 to 0fbae11 Compare December 30, 2025 17:38
@haakonvt haakonvt changed the title bump version to 8.0.0a2 release v8.0.0a2 Dec 30, 2025
@haakonvt haakonvt force-pushed the v8-change-requests-to-httpx branch 2 times, most recently from 270ac38 to e9439d4 Compare January 5, 2026 10:09
@haakonvt haakonvt force-pushed the v8-change-requests-to-httpx branch from e9439d4 to a470c70 Compare January 5, 2026 12:23
@codecov
Copy link

codecov bot commented Jan 5, 2026

Codecov Report

❌ Patch coverage is 49.22481% with 131 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (pysdk-release-v8-alpha-2@e2a64bc). Learn more about missing BASE report.

Files with missing lines Patch % Lines
cognite/client/data_classes/_response.py 20.00% 84 Missing ⚠️
cognite/client/data_classes/data_modeling/query.py 0.00% 9 Missing ⚠️
cognite/client/exceptions.py 38.46% 8 Missing ⚠️
cognite/client/_http_client.py 76.92% 6 Missing ⚠️
cognite/client/data_classes/aggregations.py 33.33% 4 Missing ⚠️
cognite/client/_api/entity_matching.py 70.00% 3 Missing ⚠️
cognite/client/_basic_api_client.py 57.14% 3 Missing ⚠️
cognite/client/data_classes/three_d.py 0.00% 3 Missing ⚠️
...nite/client/data_classes/transformations/schema.py 50.00% 3 Missing ⚠️
cognite/client/data_classes/contextualization.py 50.00% 2 Missing ⚠️
... and 6 more
Additional details and impacted files
@@                     Coverage Diff                     @@
##             pysdk-release-v8-alpha-2    #2425   +/-   ##
===========================================================
  Coverage                            ?   64.77%           
===========================================================
  Files                               ?      462           
  Lines                               ?    47228           
  Branches                            ?        0           
===========================================================
  Hits                                ?    30593           
  Misses                              ?    16635           
  Partials                            ?        0           
Files with missing lines Coverage Δ
cognite/client/_api/data_modeling/instances.py 59.69% <ø> (ø)
cognite/client/_cognite_client.py 39.17% <ø> (ø)
...ognite/client/_sync_api/data_modeling/instances.py 15.46% <ø> (ø)
cognite/client/_sync_api/entity_matching.py 29.03% <ø> (ø)
cognite/client/_sync_api/functions/__init__.py 31.70% <ø> (ø)
cognite/client/_sync_cognite_client.py 37.89% <ø> (ø)
cognite/client/config.py 59.82% <ø> (ø)
...ite/client/data_classes/data_modeling/instances.py 49.87% <ø> (ø)
cognite/client/data_classes/datapoints.py 59.44% <ø> (ø)
cognite/client/data_classes/time_series.py 40.93% <ø> (ø)
... and 24 more
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@haakonvt haakonvt force-pushed the v8-change-requests-to-httpx branch from 0ec9dc8 to f3af288 Compare January 5, 2026 12:49
@haakonvt
Copy link
Contributor Author

haakonvt commented Jan 5, 2026

/gemini review

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request prepares the v8.0.0a2 release. The most significant change is a major refactoring of the HTTP client layer to abstract away the underlying httpx library by introducing CogniteSDKResponse and CogniteHTTPStatusError. This is an excellent architectural improvement that will make the SDK more maintainable.

Other notable changes include a critical fix for blocking time.sleep in async code, improved error handling, and various refactorings for clarity and type safety. The changes are of high quality.

I have one comment regarding some redundant code.

Additionally, please note that the pull request title does not follow the Conventional Commit specification outlined in the repository's style guide (lines 168-181). For a release, a title like chore(release): release v8.0.0a2 would be more appropriate. Since this release contains breaking changes, it should also include a ! in the title, for example: chore(release)!: release v8.0.0a2 (style guide line 183).

@haakonvt haakonvt force-pushed the v8-change-requests-to-httpx branch from f3af288 to 1981df1 Compare January 5, 2026 13:14
@erlendvollset
Copy link
Collaborator

We should also fix the proxy attribute on GlobalConfig, which still leaks httpx internals.

@haakonvt haakonvt mentioned this pull request Jan 6, 2026
@haakonvt
Copy link
Contributor Author

haakonvt commented Jan 6, 2026

Closing in favor of: #2435

@haakonvt haakonvt closed this Jan 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants