-
Notifications
You must be signed in to change notification settings - Fork 6
Fix Windows service startup timeout by calling set_service_running() #500
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @Hmnt39, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a critical issue where Windows services could time out during their startup phase, leading to premature termination. The core change involves ensuring that the service explicitly reports its running status to the Windows Service Control Manager early in its initialization, thereby preventing the default timeout mechanism from interfering. This enhancement improves the reliability and stability of services deployed on Windows environments. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request correctly addresses a timeout issue for Windows services by calling handle.set_service_running() at the beginning of the service's lifecycle. This prevents the Windows Service Control Manager from terminating the service for taking too long to start. The change is implemented correctly in cognite/extractorutils/unstable/core/runtime.py, and the corresponding test in tests/test_unstable/test_runtime.py has been updated to verify this new behavior. The version updates and changelog entry are also appropriate. The changes are solid and I have no further feedback.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #500 +/- ##
==========================================
- Coverage 81.04% 81.02% -0.02%
==========================================
Files 43 43
Lines 4210 4211 +1
==========================================
Hits 3412 3412
- Misses 798 799 +1
🚀 New features to boost your workflow:
|
|
🦄 |
Added
handle.set_service_running()call to report service status to Windows Service Control Manager, preventing the service from timing out instartingstate. Updated test case to verify the method is called during service initialization.