ZSH argcomplete: call compinit only if needed#40
Open
mjbogusz wants to merge 1 commit intocolcon:masterfrom
Open
ZSH argcomplete: call compinit only if needed#40mjbogusz wants to merge 1 commit intocolcon:masterfrom
mjbogusz wants to merge 1 commit intocolcon:masterfrom
Conversation
Author
|
As ros2/ros2cli#750 was merged, I'm marking this as ready for review - even if it doesn't handle some edge cases, it should be good enough for most use cases that are broken right now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ref ros2/ros2cli#534 (comment)
As stated in the comment above, I'm not sure if this is the most correct solution... but it should help a bit.