Adds the data property for describing a String in more detail#8
Open
semmons99 wants to merge 1 commit intocollection-json:masterfrom
Open
Adds the data property for describing a String in more detail#8semmons99 wants to merge 1 commit intocollection-json:masterfrom
data property for describing a String in more detail#8semmons99 wants to merge 1 commit intocollection-json:masterfrom
Conversation
mamund
requested changes
Apr 29, 2017
Member
mamund
left a comment
mamund
left a comment
There was a problem hiding this comment.
Sorry I missed this PR. would you consider adding a list of possible values for "type"? I assume this is similar to "type" for HTML.INPUT, right? maybe that is the list (or a subset of those items).
Also, there should be some language on how a parser deals with "unsupported" or "unknown" values of type (e.g. "if the value of type is unsupported or unknown or invalid, the value of type SHOULD be assumed to be text) or whatever
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.