Skip to content

feat: don't show descriptions from non verbose search output #222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
esadek wants to merge 1 commit into
base: main
Choose a base branch
from
+10 −10
Open

feat: don't show descriptions from non verbose search output #222

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cmd/dbc/search.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,7 @@ func viewDrivers(d []dbc.Driver, verbose bool) string {
}

if !verbose {
l.Item(nameStyle.Render(driver.Path) + " - " + descStyle.Render(driver.Desc) + suffix)
l.Item(nameStyle.Render(driver.Path) + suffix)
continue
}

Expand Down
18 changes: 9 additions & 9 deletions cmd/dbc/search_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,11 +24,11 @@ func (suite *SubcommandTestSuite) TestSearchCmd() {
m := SearchCmd{}.GetModelCustom(
baseModel{getDriverRegistry: getTestDriverRegistry,
downloadPkg: downloadTestPkg})
suite.validateOutput("• test-driver-1 - This is a test driver\r\n"+
"• test-driver-2 - This is another test driver\r\n"+
"• test-driver-manifest-only - This is manifest-only driver\r\n"+
"• test-driver-no-sig - Driver manifest missing Files.signature entry\r\n"+
"• test-driver-invalid-manifest - This is test driver with an invalid manfiest. See https://github.com/columnar-tech/dbc/issues/37.\r\n\r ", "", suite.runCmd(m))
suite.validateOutput("• test-driver-1\r\n"+
"• test-driver-2\r\n"+
"• test-driver-manifest-only\r\n"+
"• test-driver-no-sig\r\n"+
"• test-driver-invalid-manifest\r\n\r ", "", suite.runCmd(m))
}

func (suite *SubcommandTestSuite) TestSearchCmdWithInstalled() {
Expand All @@ -39,10 +39,10 @@ func (suite *SubcommandTestSuite) TestSearchCmdWithInstalled() {
m = SearchCmd{}.GetModelCustom(
baseModel{getDriverRegistry: getTestDriverRegistry,
downloadPkg: downloadTestPkg})
suite.validateOutput("• test-driver-1 - This is a test driver [installed: env=>1.1.0]\r\n"+
"• test-driver-2 - This is another test driver\r\n• test-driver-manifest-only - This is manifest-only driver\r\n"+
"• test-driver-no-sig - Driver manifest missing Files.signature entry\r\n"+
"• test-driver-invalid-manifest - This is test driver with an invalid manfiest. See https://github.com/columnar-tech/dbc/issues/37.\r\n\r ", "", suite.runCmd(m))
suite.validateOutput("• test-driver-1 [installed: env=>1.1.0]\r\n"+
"• test-driver-2\r\n• test-driver-manifest-only\r\n"+
"• test-driver-no-sig\r\n"+
"• test-driver-invalid-manifest\r\n\r ", "", suite.runCmd(m))
}

func (suite *SubcommandTestSuite) TestSearchCmdVerbose() {
Expand Down
Loading