Skip to content

fix: mdc component completions#94

Open
adamdehaven wants to merge 1 commit into
comarkdown:mainfrom
adamdehaven:fix/mdc-component-completions
Open

fix: mdc component completions#94
adamdehaven wants to merge 1 commit into
comarkdown:mainfrom
adamdehaven:fix/mdc-component-completions

Conversation

@adamdehaven

@adamdehaven adamdehaven commented May 27, 2026

Copy link
Copy Markdown
Collaborator

Description

Fixes two issues with MDC component completions:

Component names

  1. Start typing a component name ::accordio (i.e. a partial component name available in component-meta) but then press Escape to cancel auto-completion suggestions
  2. Press Ctrl + Space to re-trigger completions, and notice only components that match the entire partial component name on the line are suggested.
  3. When accepting a suggestion, the name isn't appended to the line, but instead properly replaces the entire component name to be correct.
  4. When accepting a suggestion, if the component template (e.g. YAML block for props and slot content) is already injected into the template, it does not inject another props and slot template.

Component props

Same behavior described above for 1-3, but for MDC prop names within YAML blocks.

@adamdehaven adamdehaven self-assigned this May 27, 2026
@adamdehaven

Copy link
Copy Markdown
Collaborator Author

@farnabaz @atinux I'm noticing there are no branch protections enabled for the repo (it looks like I can merge this pull request without a review, tests, etc.)

@atinux

atinux commented May 27, 2026

Copy link
Copy Markdown
Contributor

Just added @adamdehaven thank you!

@adamdehaven adamdehaven requested a review from farnabaz June 2, 2026 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants