Skip to content

Fixing minor incorrect and missing punctuation on the trading page.#584

Merged
matr1x-hackmud merged 1 commit into
comcode-org:mainfrom
jckirton:patch-1
Jan 15, 2026
Merged

Fixing minor incorrect and missing punctuation on the trading page.#584
matr1x-hackmud merged 1 commit into
comcode-org:mainfrom
jckirton:patch-1

Conversation

@jckirton

Copy link
Copy Markdown
Contributor

Problem

Minor issues in punctuation present on the trading page.

Context

@hmdunce

hmdunce commented Jan 15, 2026

Copy link
Copy Markdown
Contributor

Hmm, it seems I'm unable to approve. 🤔

@jckirton

Copy link
Copy Markdown
Contributor Author

@hmdunce are you able to do a review at all?

@hmdunce

hmdunce commented Jan 15, 2026

Copy link
Copy Markdown
Contributor

No it looks like only @comcode-org/reviewers can review. Not sure if intentional.

@jckirton

Copy link
Copy Markdown
Contributor Author

Odd. I assume you could do it before?

@hmdunce

hmdunce commented Jan 15, 2026

Copy link
Copy Markdown
Contributor

Yeah #549 ❤️

These messages have already shown up in the appropriate discord channels, and maybe it was intentional, so I won't create a separate issue or bother anyone about it (yet) 😄

@jckirton

Copy link
Copy Markdown
Contributor Author

Heh, fair enough!

@matr1x-hackmud matr1x-hackmud left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello!

Thank you for the contribution.

@matr1x-hackmud matr1x-hackmud merged commit 380924d into comcode-org:main Jan 15, 2026
4 checks passed
@seanmakesgames

Copy link
Copy Markdown
Member

Yeah #549 ❤️

These messages have already shown up in the appropriate discord channels, and maybe it was intentional, so I won't create a separate issue or bother anyone about it (yet) 😄

I have no idea what's goin' on here-- I'm gonna go look. This is not intentional.

@seanmakesgames

Copy link
Copy Markdown
Member

@hmdunce were you trying to bypass an approval or something? I'm super confused about why marto could review but you could not--

@hmdunce

hmdunce commented Jan 15, 2026

Copy link
Copy Markdown
Contributor

Hmm maybe need to wait for next wiki PR to test again. 😄

@hmdunce

hmdunce commented Jan 15, 2026

Copy link
Copy Markdown
Contributor

I just didn't see any way to review or approve, maybe I was being very stupid somehow...

@seanmakesgames

Copy link
Copy Markdown
Member

I just didn't see any way to review or approve, maybe I was being very stupid somehow...

@hmdunce
#585

@seanmakesgames

Copy link
Copy Markdown
Member

mission accomplished ™

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants