Skip to content

fix: tighten canonicalization typing and receipt boundary casts #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
GsCommand merged 1 commit into from
May 18, 2026
Merged

fix: tighten canonicalization typing and receipt boundary casts #50

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ export class CommandLayer {
signer: string;
privateKeyPem: string;
keyId: string;
canonicalization: string;
canonicalization: typeof DEFAULT_CANONICALIZATION;
verifierUrl: string;
};

Expand Down
8 changes: 4 additions & 4 deletions test/receipt.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import test from "node:test";
import assert from "node:assert/strict";
import { webcrypto } from "node:crypto";
import { verifyCommandLayerReceipt } from "@commandlayer/runtime-core";
import { verifyCommandLayerReceipt, type CommandLayerReceipt } from "@commandlayer/runtime-core";
import { createServer, type IncomingMessage, type ServerResponse } from "node:http";

import { CommandLayer } from "../src/index.js";
Expand Down Expand Up @@ -50,7 +50,7 @@ test("wrapping an action creates a receipt with required fields", async () => {
assert.equal(result.receipt.proof.signature.alg, "Ed25519");
assert.ok(result.receipt.proof.signature.value.length > 0);
assert.equal(result.receipt.proof.signature.kid, "vC4WbcNoq2znSCiQ");
assert.equal((result.receipt as Record<string, unknown>).signature_b64, undefined);
assert.equal((result.receipt as unknown as Record<string, unknown>).signature_b64, undefined);
assert.ok(result.receipt.execution.started_at);
assert.ok(result.receipt.execution.completed_at);
});
Expand Down Expand Up @@ -100,11 +100,11 @@ test("emitted receipt verifies with runtime-core and tampering is invalid", asyn
run: async () => ({ y: 2 }),
});

const verification = await verifyCommandLayerReceipt(receipt, { publicKeyPemOrDer: publicKeyPem });
const verification = await verifyCommandLayerReceipt(receipt as unknown as CommandLayerReceipt, { publicKeyPemOrDer: publicKeyPem });
assert.equal(verification.status, "VERIFIED");

const tampered = { ...receipt, output: { y: 99 } };
const tamperedVerification = await verifyCommandLayerReceipt(tampered, { publicKeyPemOrDer: publicKeyPem });
const tamperedVerification = await verifyCommandLayerReceipt(tampered as unknown as CommandLayerReceipt, { publicKeyPemOrDer: publicKeyPem });
assert.equal(tamperedVerification.status, "INVALID");
});

Expand Down
Loading