fix(claim): move SIWE to Step 1 and harden wallet auth UX#266
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
window.signInWithEthereumso inlineonclickalways resolves, and disabled the Step 1 Continue button until authentication succeeds.#siweErrorarea; clicking disables the button and showsWaiting for wallet.../Requesting wallet signature..., success showsWallet authenticatedand enables Continue, failures restore the button and display a clear error.window.ethereum,eth_requestAccountshandling with no-account error,eth_chainIdparsing, and robust handling of/api/auth/noncefailures and signature rejection (wallet error code 4001).api/auth/verify.jsto expect the exact statementAuthenticate with CommandLayer Claim activation.to ensure frontend/backend alignment.Testing
npm install(succeeded).npm testand all repository unit tests passed (SIWE-related tests remain passing as shown in suite output).npm run buildfailed because the repo does not define abuildscript (noted in output).cd examples/webhook-auto-verify && npm installandnpm run checkin that example and both succeeded.Codex Task