Claim: Connect-first wallet UX (Connect Wallet then SIWE)#267
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
public/claim.htmlstep 1 title and copy toConnect walletand clarified that the wallet signs the login message while the Ed25519 key signs agent receipts.Connect Walletbutton and a secondarySign-In with Ethereumbutton that is revealed after a successful connection, and added copy listing supported injected browser wallets (MetaMask, Rabby, Coinbase Wallet, and other EIP-1193 wallets).window.connectWalletto request accounts viaethereum.request({ method: 'eth_requestAccounts' }), surface clear errors (missing wallet, connection rejected), and displayWallet connected: 0x1234...abcdon success.window.signInWithEthereumto run after connection, fetching/api/auth/nonce, building the SIWE message, requestingpersonal_sign, posting to/api/auth/verify, and mapping visible failure states including signature rejected, nonce request failed, SIWE verification failed, domain mismatch, and unsupported chain.Testing
npm testin the repository and all automated tests passed (30tests,0failures).npm installin the root which began but produced environment warnings;npm installforexamples/webhook-auto-verifycompleted successfully.npm run buildfailed because the repository has nobuildscript (expected failure).examples/webhook-auto-verifychecks vianpm run checkwhich succeeded.Codex Task