Fix shared nav on home and claim pages#275
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
public/protocol.html/public/sdk-records.htmland to remove local CSS that conflicts with the shared pattern.Description
<nav>...</nav>block inpublic/index.htmlwith the shared container-based nav structure used bypublic/protocol.html/public/sdk-records.htmland preserved onlyHomeas the active top-nav item.<nav>...</nav>block inpublic/claim.htmlwith the same shared nav structure and preserved onlyClaimas the active top-nav item.width/marginrules from the claim page local.nav-innerCSS, leaving only alignment and sizing rules (min-height,padding,display:flex,align-items,justify-content,gap).public/protocol.htmlwas left unchanged and validated that each ofpublic/index.htmlandpublic/claim.htmlcontains exactly one<nav>block and the expected active items.Testing
npm test, which executed the test suite and produced 35 test runs with 34 passing and 1 failing test; the failing test isPOST /api/auth/verify surfaces dependency unavailable when siwe is missingintests/api-auth.test.jsand appears unrelated to the nav changes. (Test run completed; 34 passed, 1 failed.)npm run buildand confirmed there is nobuildscript in this repository, so a build step was not run.Codex Task