Update docs & tests to support proof.signature union, metadata.trace, and ERC-8211 schema wording#276
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
metadata.traceas optional correlation metadata and aproof.signatureunion shape supporting both single and multi-signature entries.json.sorted_keys.v1remains the standard receipt path anderc8211.merkle.v1is accepted at the schema/interop layer.Description
isSingleProofSignature(),isMultiProofSignature(), andgetPrimaryProofSignature()and updatedtests/verifyReceipt-runtime.test.jsto use them and to preserve legacy single-signature assertions.multi-signature proof shape does not crash runtime verifierthat injects a role-basedmetadata.proof.signature[]and asserts the verifier does not crash (expectedINVALIDfor the fixture).metadata.trace, allowed signature roles, and ERC-8211 wording constrained to schema/interoperability (pages changed:public/canonical-receipts.html,public/sdk-records.html,public/api.html,public/verify-badge-demo.html,public/ambient-verification.html).roleexist for solver/relayer/batch workflows.Testing
npm installwhich completed successfully.npm testwhich exercised the test suite and returned36tests run with35passing and1failing, where the failing test is an existing auth test (tests/api-auth.test.js) asserting503but receiving400and is unrelated to the proof/signature changes.npm run buildandnpm run typecheckbut both scripts are not present inpackage.jsonin this repository, so those steps were not executed.Codex Task