Fix admin mark_failed and add_note claim actions#305
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
ADMIN_CLAIM_ACTION_FAILEDwhen invoking admin actions on an approved claim by aligning frontend payload keys and backend handling formark_failedandadd_note.mark_failedandadd_notebehave deterministically with required inputs and produce appropriate events and transitions without weakening the status machine.Description
api/admin/claim-action.jsto requirereasonformark_failedandnotesforadd_note, allowmark_failedfrom any non-livestatus, updateclaim_requests(status = 'failed',last_error,last_error_at) for failures, and insert matchingclaim.failedevent and aclaim_status_transitionsrecord with metadata.add_noteto preserve claim status, append/updateadmin_notes, and insert aclaim.note_addedevent (message + json) without inserting a status transition.{ message, code, action, claimId, currentStatus }on unexpected failures and include adebugobject in the JSON response only whenNODE_ENV !== 'production'.public/admin/claims.htmlto sendreasonformark_failedandnotesforadd_note, and render API errors inline asAction failed: <status> — <error>with optionalDetails: <debug.message>when present.tests/api-admin-claims.test.jsto covermark_failedsuccess/failure semantics, event and transition writes,add_notebehavior, and frontend payload key expectations.Testing
npm testand all tests passed (77tests passed after changes).cd examples/webhook-auto-verify && npm run checkand the check succeeded.mark_failedandadd_notebehaviors passed in the automated test run.Codex Task