Improve Coinbase Payments transfer webhook normalization#312
Merged
GsCommand merged 1 commit intoMay 23, 2026
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
payments.transfers.*webhook events were normalized with poor subject mapping and fell back to the event id, losing transfer-specific context.Description
payments.transfers.*events innormalizeReceiptand mapsubject.typeto"payment_transfer"for those events.subject.idby preference:data.id, thendata.transfer_id, thendata.payment_id, then the event id fallback, while keeping existing transaction-hash behavior for non-transfer events.output.observationwithaccepted: true,provider: 'coinbase_cdp',event_type, and transfer-specific fields:transfer_status(derived from the event suffix), plus optionaltransfer_id,asset,amount, andnetworkwhen present.metadata.trace.tags(provider,event_type,transfer_status, and optionaltransfer_id) and preserve existing HMAC verification, signing logic, and handling for other event types.Testing
tests/api-coinbase-webhook.test.jsforpayments.transfers.completed(checks subject mapping, observation fields and local receipt verification),payments.transfers.failed(checkstransfer_status), and unknown-event fallback to event id.npm testand all tests passed (97 passed, 0 failed), including the new transfer-related tests.Codex Task