Fix schema validator to support published manifest metadata#40
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
manifest.jsonis in"publication_state": "published"with a non-nullrelease_date, while the validator only allowed pre-publication metadata; the validator needs to be state-aware so published manifests validate correctly.Description
scripts/validate-all.mjsto allowpublication_stateto be eitherrepository-validated-not-yet-publishedorpublishedand to enforcerelease_date === nullfor the former and an ISOYYYY-MM-DDstring for the latter; also updatedCHANGELOG.mdto document the validator change.Testing
npm ciandnpm run validate(the run initially failed on the manifest assertion before the fix) and after the change rannpm testandnpm run validate:schemas, all of which passed.Codex Task