Skip to content

Show the column drag handle on hover only #1239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gciotola merged 1 commit into from
Sep 30, 2026
Merged

Show the column drag handle on hover only #1239

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions packages/app-elements/src/ui/resources/useResourceFilters/ColumnsMenuItems.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -236,6 +236,8 @@ function SortableColumnItem({
className={cn(
"relative touch-none",
"[&:hover>*:first-child]:bg-gray-100 [&:hover>*:first-child]:rounded",
// the handle shows on the row's hover, wherever the pointer is on it
"[&:hover>*:last-child]:opacity-100",
{ "z-10": isDragging },
)}
>
Expand Down Expand Up @@ -269,7 +271,11 @@ function SortableColumnItem({
// rest of the row keeps the pointer of a click. Pressing here drags the
// row all the same, the event reaching the row's own listener.
"flex text-gray-400 rounded cursor-grab",
// a keyboard user lands here on Tab, and has to see it
// Hidden at rest, so the menu reads as a list of columns rather than
// of handles: it shows on the row's hover (see above), for the row
// being moved, and for a keyboard user who lands here on Tab.
"opacity-0 focus-visible:opacity-100",
{ "opacity-100!": isDragging },
"outline-hidden focus-visible:text-gray-800 focus-visible:bg-gray-100",
)}
>
Expand All @@ -288,11 +294,6 @@ function LockedColumnItem({ entry }: { entry: TableColumnEntry }): JSX.Element {
disabled
aria-disabled
/>
{/* no handle to grab, only its outline, so the column reads as part of
the list and stays aligned with the others */}
<span className={cn(handleClassName, "flex text-gray-200")} aria-hidden>
<Icon name="dotsSixVertical" size={16} />
</span>
</div>
)
}
Expand Down
Loading