refactor: stop using SDK exports that SDK 8 drops; integration on dependency changes - #251
Merged
Merged
Conversation
Compatible with the current SDK 6, and one step less for SDK 8: - tags: the resource classes are only used for their TYPE constant, replaced by the type names (still checked against TaggableResourceType) - links: QuerySort instead of QueryArraySortable | QueryRecordSortable - triggers: the fields of the retrieve params typed through QueryParamsRetrieve instead of QueryRecordFields - provisioning tests: the list mocks accept a query, as the resources ones do (the next provisioning-sdk sends page[number]=1) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
An SDK update above all must work against the real API. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
3 of 4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The changes from the SDK 8 work (#250) that don't depend on SDK 8: they work with the current SDK 6 and leave #250 with only what SDK 8 needs.
Skus,Orders, …), which SDK 8 no longer exports, were only used for theirTYPEconstant: replaced by the type names, still checked againstTaggableResourceType.QuerySortinstead ofQueryArraySortable | QueryRecordSortable(both SDKs export it).fieldstyped throughQueryParamsRetrieveinstead ofQueryRecordFields.page[number]=1).pnpm-workspace.yaml,pnpm-lock.yaml): an SDK update above all must work against the real API. README updated.Test plan
pnpm build,pnpm lint; tags, links, triggers, provisioning suites pass on SDK 6🤖 Generated with Claude Code