fix(metrics)!: fbt requires item IDs and prints readable results - #269
Merged
Merged
Conversation
The Metrics API refuses an FBT query without `filter.line_items.item_ids` (400 Bad Request) and documents no other filter for it, so `--in` is now required and `--filter` is gone: without --in the command sent an empty query, and with it the filter was mixed into a query the API doesn't define. The --in description says that the orders must contain all the items (FBT's `in` is a logical AND). The results were printed as `[object Object],…`: each item is now a line with its name, type, ID and number of orders. BREAKING CHANGE: metrics:fbt no longer has the --filter flag and requires --in. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
3 of 4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
metrics:fbthad two problems, checked against the FBT documentation of the Metrics API.Changes
--inis required,--filteris removed.filter.line_items.item_ids.inand answers400 Bad Requestwithout it. It documents no other filter for FBT, and the MCP Metricsfbttool schema likewise accepts onlyitem_ids.{}without--in, and with--init mixed the user's--filterinto the query.--indescription now says that the orders must contain all the items: FBT'sinis a logical AND, unlike the standard filters.String(data), which gives[object Object],….Tests
5
fbttests, 22 for the plugin:--inflags;--inrequired;--filterrefused;4 of them fail with the previous code.
The change is breaking for the command (
--filterremoved). The plugin goes to its next major with oclif 5 anyway (2.0.0).🤖 Generated with Claude Code