Fix npm audit vulnerabilities in theme dependencies#285
Merged
Conversation
npm audit fix bumps transitive deps flagged by Dependabot: shell-quote (critical), fast-uri and flatted (high), picomatch and ws (moderate).
sockjs (via webpack-dev-server) pins uuid 8.x, which has a buffer bounds-check advisory. npm's suggested fix downgrades webpack-dev-server to 1.x, so force uuid 11.1.1 instead; sockjs only uses uuid.v4, which is unchanged. Dev server verified to boot with the override.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clears all 6 open Dependabot alerts plus the remaining
npm auditfindings in the theme (11 total: 1 critical, 3 high, 7 moderate).What
npm audit fixbumps the transitive deps flagged by Dependabot: shell-quote (critical, GHSA-w7jw-789q-3m8p), fast-uri ×2 (high), flatted (high), picomatch and ws (moderate). Lock-file-only change.overridesentry forcing uuid to ^11.1.1. sockjs (via webpack-dev-server) pins uuid 8.x, and npm's suggested "fix" is a downgrade to webpack-dev-server 1.x — not sensible. sockjs only usesuuid.v4, whose API is unchanged in v11.Verification
npm auditreports 0 vulnerabilitiesnpm run buildcompiles cleanly (webpack 5.107.2)npm run devboots webpack-dev-server with the uuid overridecomposer lintandcomposer testpass