Fall back to the unversioned banner slug - #48
Merged
Merged
Conversation
get_header keys on APP, but almalinux-vm, debian-vm and ubuntu-vm set APP again with the release before drawing, so they ask for almalinux10vm, debian13 and ubuntu26.04vm. None of those was ever generated -- the generator keys on the first APP= line -- so the request 404s and no banner is drawn. Only a trailing version or VM/LXC is dropped and retried, so the walk stops at the first word that is neither: "Home Assistant OS" still resolves to homeassistantos alone and cannot land on a homeassistant banner. The cache is keyed on the slug that resolved, not the one asked for. Fixes community-scripts/ProxmoxVE#17383
Contributor
Try this branchThe engine and the scripts resolve independently, so a production script can COMMUNITY_SCRIPTS_CORE_URL=https://raw.githubusercontent.com/community-scripts/core/fix/vm-banner-versioned-app \
bash -c "$(curl -fsSL https://raw.githubusercontent.com/community-scripts/ProxmoxVED/main/ct/debian.sh)"Swap This PR touches Run a script from a fork as wellcurl -fsSL https://raw.githubusercontent.com/community-scripts/core/fix/vm-banner-versioned-app/tools/run.sh |
bash -s -- https://raw.githubusercontent.com/YOU/ProxmoxVED/your-branch ct/debian.sh \
https://raw.githubusercontent.com/community-scripts/core/fix/vm-banner-versioned-appNote that Useful flags while testing
|
MickLesk
added a commit
that referenced
this pull request
Sep 19, 2026
header_info handed get_header "${APP,,}" with spaces turned into
hyphens. That was harmless while get_header ignored its argument, but
#48 made the argument live, so the lookup started asking for
home-assistant-os instead of homeassistantos: ten VM scripts with a
multi-word APP lost the banner they had, and the three with a versioned
APP never got theirs, because a hyphenated string is one word and the
new fallback had nothing to drop.
Pass the name through unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✍️ Description
get_header()builds the banner slug fromAPPat call time. Three VM scripts setAPPa second time with the release before drawing, so they ask for a banner that was never generated — the generator keys on the firstAPP=line:APP=vm/almalinux-vm.shAlmaLinux ${var_version} VMalmalinux10vmvm/debian-vm.shDebian ${var_version}debian13vm/ubuntu-vm.shUbuntu ${var_version} VMubuntu26.04vm🔗 Related Issue
Fixes community-scripts/ProxmoxVE#17383
✅ Prerequisites (X in brackets)
_cs_header_slugsis not exported through a loader snapshot;get_headerkeeps its signature🧪 Testing
_cs_header_slugsextracted from the file and run against 11 cases — all pass:get_headerend to end against local fixtures:Not run on a Proxmox host.
bash -npasses.🛠️ Type of Change (X in brackets)