Add nightly build for wasmtime#2073
Draft
MaxGraey wants to merge 1 commit into
Draft
Conversation
Build RequiredThe following additions require CE to build artifacts before deployment:
Please ensure these have been built and uploaded to S3 before merging, or coordinate with the CE team. |
mattgodbolt
reviewed
May 7, 2026
|
|
||
| if install_nightly; then | ||
| echo "Installing trunk versions" | ||
| ce_install 'wasmtime dev' |
Member
There was a problem hiding this comment.
Agreed - we install all nightly things all the time, once daily. no need to special case it here, unless I'm really missing something
Contributor
Author
There was a problem hiding this comment.
So I can remove this line and nightly dev from wasm.yaml trigger automatically?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The wasmtime nightly (dev) release already includes tarball artifacts, so it seems we can define everything declaratively. However, I’m not entirely sure how to launch
wasm.yamlon a daily basis. I’m not convinced thatinstall_libraries.shis the best place for this.