Skip to content

[test] Drop crash markers that pass the isolation sweep #83

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
aaronj0 wants to merge 1 commit into
base: main
Choose a base branch
from
+0 −11
Draft

[test] Drop crash markers that pass the isolation sweep #83

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion test/test_advancedcpp.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -819,7 +819,6 @@ def test24_typedef_to_private_class(self):

assert cppjit.gbl.TypedefToPrivateClass().f().m_val == 42

@mark.xfail(run=False, reason="Crashes")
def test25_ostream_printing(self):
"""Mapping of __str__ through operator<<(ostream&)"""

Expand Down
2 changes: 0 additions & 2 deletions test/test_boost.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,6 @@ def test01_any_class(self):

assert std.list[any]

@mark.xfail(run=False, reason="boost::any casting crashes")
def test02_any_usage(self):
"""boost::any assignment and casting"""

Expand Down Expand Up @@ -125,7 +124,6 @@ def setup_class(cls):
cppjit.include("boost/variant/variant.hpp")
cppjit.include("boost/variant/get.hpp")

@mark.xfail(run=False, reason="boost::variant access crashes")
def test01_variant_usage(self):
"""boost::variant usage"""

Expand Down
3 changes: 0 additions & 3 deletions test/test_concurrent.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@ def setup_class(cls):

cppjit.gbl.Workers.calc.__release_gil__ = True

@mark.xfail(run=False, reason="Crashes")
def test01_simple_threads(self):
"""Run basic Python threads"""

Expand All @@ -35,7 +34,6 @@ def test01_simple_threads(self):
for t in threads:
t.join()

@mark.xfail(run=False, reason="Crashes")
def test02_futures(self):
"""Run with Python futures"""

Expand Down Expand Up @@ -266,7 +264,6 @@ def test():
for t in threads:
t.join()

@mark.xfail(run=False, reason="Crashes")
def test07_overload_reuse_in_threads_wo_gil(self):
"""Threads reuse overload objects; check for clashes if no GIL"""

Expand Down
5 changes: 0 additions & 5 deletions test/test_stltypes.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
import py
from pytest import mark, raises, skip
from support import (
IS_CLANG_DEBUG,
IS_CLANG_REPL,
IS_CLING,
IS_LINUX_ARM,
Expand Down Expand Up @@ -1839,10 +1838,6 @@ def test01_string_through_string_view(self):
assert countit(v) == 4
assert countit_cr(v) == 4

@mark.xfail(
run=not (IS_CLANG_DEBUG or IS_CLING),
reason="Crashes on ClangRepl with 'toString not implemented', and on Cling",
)
def test02_string_view_from_unicode(self):
"""Life-time management of converted unicode strings"""

Expand Down
Loading