Skip to content

fix: keep the demo feedback dialog narrower than the screen - #387

Merged
ianmiell merged 2 commits into
mainfrom
fix/demo-feedback-dialog-size
Nov 6, 2026
Merged

ianmiell merged 2 commits into
mainfrom
fix/demo-feedback-dialog-size

Conversation

@alpoi

@alpoi alpoi commented Nov 2, 2026

Copy link
Copy Markdown
Contributor

The demo's feedback dialog (#386) stretched across the whole window.

Cause

Volt's Dialog adds w-1/3 and max-w-screen to its root. They beat the w-full max-w-lg passed in, so the width came out as w-full with no cap: 1024px wide in a 1024px window.

Fix

Give the dialog an inline width, min(32rem, calc(100vw - 2rem)), which wins over the root classes. Measured in the browser:

Viewport Before After
1024×768 1024px 512px
375×812 375px (full width) 343px (16px each side)

A spec checks for the inline width.

Other dialogs that pass class="w-full max-w-2xl" probably have the same problem. They're left alone here.

🤖 Generated with Claude Code

Volt's Dialog adds w-1/3 and max-w-screen to its root, which beat the
w-full max-w-lg passed in, so the dialog stretched across the whole
window. An inline width (min(32rem, 100vw - 2rem)) wins over the classes.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Nov 2, 2026 •

Copy link
Copy Markdown

Important

  • Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: 41ef8686-d136-4fb1-b81b-42d047bf56f0
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Tip

🎯 Customize your risk assessments

Guide how CodeRabbit assesses merge risk and security architecture risk. Highlight sensitive changes and explain your security boundaries using Merge Risk Instructions and Security Risk Instructions in your review settings. Security architecture risk assessments require the Advanced plan or above.

✅ Automatic approvals, with your rules

Let CodeRabbit approve pull requests once required threads are resolved, pre-merge checks pass, and your risk limits are met. Enable Automatic approvals in review settings, with overrides for teams or file paths.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@ianmiell
ianmiell merged commit 5e406cc into main Nov 6, 2026
21 of 22 checks passed
@ianmiell
ianmiell deleted the fix/demo-feedback-dialog-size branch November 6, 2026 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants