Repository navigation
fix: keep the demo feedback dialog narrower than the screen - #387
Merged
Merged
Conversation
Volt's Dialog adds w-1/3 and max-w-screen to its root, which beat the w-full max-w-lg passed in, so the dialog stretched across the whole window. An inline width (min(32rem, 100vw - 2rem)) wins over the classes. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
|
ianmiell
approved these changes
Nov 6, 2026
ianmiell
approved these changes
Nov 6, 2026
ssherar
approved these changes
Nov 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The demo's feedback dialog (#386) stretched across the whole window.
Cause
Volt's
Dialogaddsw-1/3andmax-w-screento its root. They beat thew-full max-w-lgpassed in, so the width came out asw-fullwith no cap: 1024px wide in a 1024px window.Fix
Give the dialog an inline width,
min(32rem, calc(100vw - 2rem)), which wins over the root classes. Measured in the browser:A spec checks for the inline width.
Other dialogs that pass
class="w-full max-w-2xl"probably have the same problem. They're left alone here.🤖 Generated with Claude Code