Repository navigation
Fix connector creation and gate macOS releases on local and OAuth UI journeys - #18
Merged
Merged
Conversation
🚀 Deploying Preview to Cloudflare 🚀Preview Deployments by commit
|
kasperjunge
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Saving a new connector assigned a local UUID before choosing create versus update, causing a 404. Keep its ID empty until the backend responds, separate credential naming from connector identity, and preserve credential references and canonical IDs across retries. Also fix the arguments editor’s border intercepting clicks and keep connector details/settings attached when an offline OAuth draft receives its backend ID.
The required macOS artifact acceptance job now runs two precompiled XCUITest journeys against the exact installed DMG:
No API shortcut creates or enables connectors. Both journeys must pass with no skipped tests. Preserve xcresult screenshots and protocol evidence on failure. The fixture uses synthetic credentials, temporary data, and process-local certificate trust; it never accesses real accounts or the login Keychain. Local runs use a disposable app identity; CI preserves the release identity. SwiftPM, macOS 14+ compatibility, shared backend, Enterprise/Community, and Windows behavior remain unchanged.
Prepare desktop 0.2.2. Local validation: both packaged UI journeys passed (2 tests, 0 failures), native regression/backend/lifecycle tests passed, 26 policy/fixture tests passed, and changed Python helpers passed Ruff. A mutation restoring the original UUID bug failed the intended regression assertion. PR CI run 38164437123 passed policy, macOS, Windows, and unchanged-DMG acceptance. The fresh-Mac OAuth audit confirms one browser sign-in, one PKCE exchange, one refresh, and three authenticated agent calls. Shared Semgrep reports existing findings outside this desktop change.