Repository navigation
docs pass: README, SKILL.md, MCP README and --help tell one story (claimed, badge-only proof, person reviews, claim --check records proof) - #32
Merged
Conversation
…I errors print code + hint - pnpm workspace: packages/cli (@rgstr/cli) and packages/mcp (@rgstr/mcp 0.0.1) - claim, route and check flows moved out of index.ts into claim-flow.ts, route-flow.ts, check-flow.ts so the MCP server runs exactly the CLI's code - RgstrApiError carries code, hint, requestId, details; the CLI prints the hint last, --json includes code/hint/requestId; claim --check reads 422 proof_not_found as 'no proof yet' - MCP server: rgstr_whois/search/check, claim/setup/route plan+apply, rgstr_claim_check, rgstr_login; errors are isError results with the same envelope - SKILL.md: MCP section + the errors rule; changesets for both packages
- rgstr_login no longer hangs when the device-code request fails before a prompt; after login the one organization becomes active (rememberOrganization, shared with rgstr login) - stored plans remember the organization and host they were made for; apply refuses a different one - rgstr_setup_apply plans again and refuses when the files changed since the plan - isError text puts the envelope first so the hint is the last line, as in the CLI
…m (fingerprint includes the current file bytes)
…; a failed /api/v1/me after login forgets the stored organization - rgstr_claim_apply / rgstr_setup_apply / rgstr_route_apply accept plan_id only; the name/raw-argument paths are gone - claim plans carry a byte fingerprint of the READMEs they would edit (setup already did); a changed file, organization or host answers isError code plan_stale, hint "Run rgstr_<x>_plan again and show the user the new plan" - rememberOrganization (rgstr login and rgstr_login): when /api/v1/me fails after approval, the remembered organization is cleared and the error says "Signed in, but no organization was selected; run `rgstr org use <slug>`" (no_organization) - SKILL.md / README: no apply without a plan; plan_stale
… so rgstr_claim_apply can open the badge pull request
…kout has an origin remote
…med, badge-only proof, person reviews, claim --check records proof
Contributor
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
👀 2 findings need your review
Devin reviewed all 2 findings on 99e1c08 and left them for you. Click a finding below to jump to its comment.
For your review (2)
View all findings in Devin Review
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
- search: rgstr.owner is the organization's display name (a string); the CLI prints it again (test against the real API shape) - rgstr_login tracks the outcome: call again for waiting / approved (and for which organization) / rejected / expired / failed with the next step; no_credentials hints mention the last login outcome; the flow is injectable for tests - claim plans fingerprint the target manifests too (a renamed package is a new plan); route plans are pinned to the organization they were made for (plan_stale on mismatch)
…ever replace the tool's own error
…nization switch, search shows the organization
Contributor
|
Fixed in #31 |
Contributor
|
By design — see the #31 thread (forgetting a possibly foreign organization when |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Docs pass over everything a reader of this repo meets — root
README.md,packages/cli/README.md,packages/mcp/README.md,skills/rgstr/SKILL.mdand every command's--help— so they say the same thing as each other, as the code, and as rgstr.org after computesdk/benchmarks-platform#807: the README badge is the only proof, every claim is an application a person reviews (a found badge is evidence, not approval),claim --checkis not a read (it records the proof for the claim you filed), "verified" is paid identity verification only, "organization" never "org",rgstr setupwithuseas the hidden alias.Branched off
mainwith the branch of #31 (devin/1792533348-rgstr-mcp) merged in first, so this reads as post-merge. Files #31 owns are touched only where the docs pass needed it: one output string inpackages/mcp/src/server.ts("already under review or verified" → "or claimed") and thergstr_claim_checkrow inpackages/mcp/README.md.CHANGELOG.mduntouched; a changeset (.changeset/docs-pass-one-story.md, patch for both packages) covers the user-visible wording changes.skills/rgstr/SKILL.mdand the platform'slib/registry/skill.tsmirror changed together (byte-equal) — the platform PR carries the mirror.What was wrong → what it says now
packages/cli/README.mdrgstr claim --checkis read-only: it tells you which README the badge was found in."--here"which verifies on the next publish"whois: "(unclaimed / claimed / verified) … whether it is disputed"RGSTR_OAUTH_SCOPE)rgstr claim --check)"; new paragraph: a found badge is evidence, a person reviews every claim; "verified" is paid identity verification on top of a claimnpx @rgstr/cli claimnpx @rgstr/cli@latest claim(as the root README and the skill)skills/rgstr/SKILL.md(served at rgstr.org/skills/rgstr/SKILL.md)claim --check)claim --checkis not a read: it records the proof for a claim the user already confirmed."rgstr_claim_checkrecords the proof and can complete the claim."rgstr_claim_checkisclaim --check: it records the proof for a filed claim, so it is not a read."<name>: verified via …means it is in"<name>: proof found via …means the badge is attached to the application"unclaimed/claimed/verified)"packages/mcp/README.mdrgstr_claim_check"looks for the badge; records the proof, can complete the claim"rgstr claim --check: looks for the badge and records the proof for a filed claim; a person then approves"--help(packages/cli/src/index.ts) and CLI outputrgstr — claim, verify and route package namesrgstr — claim, prove and route package names--check: "look for the proof: the badge in the repo README on GitHub, or in the README of the published package"--here: "it then verifies on the next publish (…) rather than on merge"claim --checkoutput<name>: verified via … — …/Proof verified and attached to your application<name>: proof found via … — …/Proof found and attached to your application(claim-flow.ts)<name>: verified — your organization (already) claims it.<name>: already claimed by your organization.claim.ts, and its test)--hererefusal "(verifies on the next publish)"server.ts)Read, nothing to change
Root
README.md;packages/mcp/README.mdConfigure / Login / plan→apply /plan_stale/ Errors sections;packages/mcp/src/server.tstool titles and descriptions;packages/cli/src/check.tsoutput;login/logout/whoami/org/status/whois/route/search/setuphelp text;rgstr usestays a hidden alias;CHANGELOG.md.Checks
pnpm install(thepackages/mcpnode_modules were missing after the workspace move), thenpnpm build && pnpm typecheck && pnpm lint && pnpm test: exit 0 — cli 106 tests, mcp 14.Was flagged, fixed upstream
rgstr searchreado.rgstr.owner?.slugwhile the API sends the slug string — fixed in @rgstr/mcp: rgstr as MCP tools (plan/apply, confirm before apply); API errors print code + hint #31b8115607(api-types.tsowner?: string | null), merged in here; the README now says the command shows the claiming organization.Link to Devin session: https://app.devin.ai/sessions/ab74b85cc8ad4981a5b7e9ea55d51490
Open in Devin Desktop: https://app.devin.ai/desktop/session/ab74b85cc8ad4981a5b7e9ea55d51490?variant=devin
Requested by: @HeyGarrison