Conversation
…use I just couldn't stand it being that out of date any longer.
…0", because I just couldn't stand it being that out of date any longer." This reverts commit 3c2471e.
…se I just can't stand it being that out of date any longer.
|
Test summaryRun details
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Cloud |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2375 +/- ##
==========================================
- Coverage 85.74% 85.73% -0.01%
==========================================
Files 722 722
Lines 37223 37223
Branches 9478 9478
==========================================
- Hits 31915 31913 -2
- Misses 5003 5005 +2
Partials 305 305
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
lgtm! 🎉
We'll also want to update the documentation to the latest build to reflect this change. That's the bottom of the first page here.
scytacki
left a comment
scytacki
left a comment
There was a problem hiding this comment.
I'd prefer that we just remove it. Otherwise we're going to have do an extra commit every time we do a release to update it. With it removed the version in the UI will show up as "unknown".
It should get added automatically to releases when we follow the usual release steps that we do here:
https://github.com/concord-consortium/docs/blob/main/docs/%F0%9F%9A%80%20Release%20%26%20Deploy%20Processes/CLUE.md
With a little more work we can turn that "unknown" into the the name of the branch that is deployed.
3 participants
Update version number from "4.3.0" to "5.15.0", because I just can't stand it being that out of date any longer.