Add support for disabling service links

[mreiche]

Existing Issue

• No issue filed

Why do we need this PR?

In some Kubernetes environments and namespaces, the concourse pods get environment variables that cannot be parsed by the entrypoint. This will result in Pod startup failures like:

error: invalid argument for flag `--postgres-port' (expected uint16): strconv.ParseUint: parsing "tcp://172.30.163.53:5432": invalid syntax

This happes in the Concourse chart, when you don't use the built-in PostgreSQL chart, but another one like:

postgresql:
  enabled: false

In this case, Kubernetes provides "invalid" environment variables.

Changes proposed in this pull request

This change allows administrators to disable service links environment variables in workload pods by setting:

enableServiceLinks: false

Contributor Checklist

• Variables are documented in the README.md
• Which branch are you merging into?
  • master is for changes related to the current release of the concourse/concourse:latest image and should be good to publish immediately
  • dev is for changes related to the next release of Concourse (aka unpublished code on master in concourse/concourse)

Reviewer Checklist

This section is intended for the core maintainers only, to track review progress. Please do not
fill out this section.

• Code reviewed
• Topgun tests run
• Back-port if needed
• Is the correct branch targeted? (master or dev)

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: mreiche / name: Mike Reiche (ed085d7)

[taylorsilva]

Thanks for the PR! Will review sometime this week

[taylorsilva]

I was having trouble understanding how this conflict with service links was happening. I eventually figured out it's because of legacy "Docker Container links" that k8s supports:

• Code that creates the _PORT env var: https://github.com/kubernetes/kubernetes/blob/dd2d12f6dc0e654c15d5db57a5f9f6ba61192726/pkg/kubelet/envvars/envvars.go#L85-L91
  • I'm guessing this means the postgres service in your cluster is named concourse-postgres, resulting in the env var CONCOURSE_POSTGRES_PORT and this error
• Got there from reading this doc: https://kubernetes.io/docs/concepts/services-networking/service/#environment-variables

Now that I understand how that's happening, I feel confident accepting this PR.