[3.14] Install build-details.json from shared library build
#858
+4
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Install `build-details.json` from shared library build rather than the static build, as the latter does not include the data needed to build extensions, and therefore it is not useful for cross-compilation. This is backported from conda-forge#842, but unlike that PR it should not break anything. Signed-off-by: Michał Górny <mgorny@quansight.com>
Add the `ripgrep` dependency that is used in the `prefix-replacement` test. Since it is missing, the test never really greps and therefore does not actually test. Signed-off-by: Michał Górny <mgorny@quansight.com>
5 tasks
Contributor
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( I do have some suggestions for making it better though... For recipe/meta.yaml:
This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/21838650228. Examine the logs at this URL for more detail. |
Contributor
|
Hi! This is the friendly conda-forge automerge bot! I considered the following status checks when analyzing this PR:
Thus the PR was passing and merged! Have a great day! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
0(if the version changed)conda-smithy(Use the phrase@conda-forge-admin, please rerenderin a comment in this PR for automated rerendering)This is split from #842 to fix
build-details.jsonin Python 3.14, as suggested by @rgommers. Given that this file is new to Python 3.14 and the current version is pretty broken per se, it's unlikely for this to actually cause any issues.