Conversation
Co-authored-by: jaimergp <jaimergp@users.noreply.github.com>
jaimergp
left a comment
There was a problem hiding this comment.
A few cosmetic comments, but unless I understood wrong, there's a problem with the _ OCI-encoding.
|
Good catch @jaimergp! I reran my notebooks with Interestingly enough, we apparently have no build strings with a double underscore in either |
|
Thanks for the additional comments @jaimergp! Any thing else you can see? |
|
Nothing too big, just a couple of observations:
|
|
pre-commit.ci autofix |
for more information, see https://pre-commit.ci
|
|
||
| - `<OCI-compatible channel path>`: `^[a-z0-9]+((\.|_|__|-+)[a-z0-9]+)*(\/[a-z0-9]+((\.|_|__|-+)[a-z0-9]+)*)*$` (same as the regex for an OCI repository `<name>`) | ||
| - `<OCI-compatible label>`: `^[a-z0-9]+((\.|_|__|-+)[a-z0-9]+)*(\/[a-z0-9]+((\.|_|__|-+)[a-z0-9]+)*)*$` (same as the regex for an OCI repository `<name>`) | ||
| - `<OCI-compatible subdir>`: `^[a-z0-9]+(-[a-z0-9]+)*$` |
There was a problem hiding this comment.
This is the same as the one proposed in #116, right? We should update this part to refer to that one once accepted.
Co-authored-by: jaimergp <jaimergp@users.noreply.github.com>
Co-authored-by: jaimergp <jaimergp@users.noreply.github.com>
Co-authored-by: jaimergp <jaimergp@users.noreply.github.com>
|
I was thinking on this more and I think we should not use the
Thoughts @jaimergp? |
|
All of that is currently valid and sound. I'm just worried that we are being lucky now with no conflicts in the filename prefixes (I do second dropping I just don't see the pain in prefixing metadata files with But if you think the burden of prefixing |
|
Hmmm. Maybe the right thing is to distinguish between the abstract url given to conda versus the storage location on disk. We can specify that more clearly in the CEP. |
This draft CEP has an updated specification for storing conda packages as OCI artifacts. It is an updated form of the specification in PR #70, given the feedback on the previous PR.
Rendered CEP