readability edits for CEP-21#130
Draft
h-vetinari wants to merge 1 commit into
Draft
Conversation
h-vetinari
commented
Aug 30, 2025
Comment on lines
34
to
36
| > * (Typed) repodata parsers would need to be updated to handle the new field. | ||
|
|
||
| We propose that these reasons no longer hold with [sharded repodata](https://github.com/conda/ceps/blob/main/cep-0016.md). |
Author
h-vetinari
commented
Aug 30, 2025
Comment on lines
-37
to
+38
| **It would require extending the repodata schema, currently not formally standardized.** | ||
| ### Re: "It would require extending the repodata schema, currently not formally standardized." |
Author
There was a problem hiding this comment.
The screenshot above also shows that the current highlight makes it seem like part of the regular text of the CEP. I don't care about the exact formatting, as long as it is clear that it's a point being addressed.
Contributor
|
I understand the edits but now the part about that the run exports are stored inside the repodata is part of the discussion. Maybe we should then clarify this in the (new) specification section with MUST? |
Author
|
I don't know the process for editing accepted CEPs; in any case, I rely on you the author to make those changes, I just wanted to get the ball rolling. :) If you want I can give you collaborator rights on my fork, then you can push directly into this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

While reading https://github.com/conda/ceps/blob/main/cep-0021.md for work on #129, I noticed some minor issues, which I'm suggesting to fix here.
The big issue that I don't know how to fix is that the "Specification" section is IMO mislabeled, as it only contains discussion of reasons that CEP 12 had brought for not embedding run-exports into the regular repodata. The only language that uses authoritative keywords (MAY, MUST) is under "Patching" (though that's also mixed with non-technical language, e.g. "We do not see a reason how [...]"), so presumably that must be the entirety of the specification?
CC @baszalmstra