feat: address copy feedback, E2E tests, env docs, contributing guide (#479, #480, #481, #482) - #515
Open
SweetBoy-eth wants to merge 5 commits into
Open
Conversation
…onduit-protocol#479) Adds a new CopyableAddress component that wraps truncated addresses with copy-to-clipboard functionality. Shows a check icon for 2 seconds after a successful copy, providing visual feedback to users. Components updated to use CopyableAddress: - ConnectButton: connected wallet address - StreamCard: counterparty and token addresses - OperatorInfo: delegated operator address - Stream detail page: stream, sender, recipient, and token addresses - Transactions page: transaction hashes with CopyHashButton Closes conduit-protocol#479
…nduit-protocol#480) Adds Playwright E2E testing infrastructure with tests for wallet disconnection scenarios: - wallet-disconnect.spec.ts: Tests disconnecting while dashboard is loading to ensure no stale data or crashes occur - playwright.config.ts: Playwright configuration for Chromium - Updated .gitignore to exclude Playwright artifacts - Added test:e2e and test:e2e:ui scripts to package.json Closes conduit-protocol#480
…protocol#481) Adds detailed documentation for all NEXT_PUBLIC_* environment variables: - docs/environment-variables.md: Complete reference table with descriptions, defaults, and demo mode behavior - Updated .env.example with NEXT_PUBLIC_DEMO_MODE variable - Updated CONTRIBUTING.md to reference the new documentation Variables documented: - NEXT_PUBLIC_SOROBAN_RPC_URL (required) - NEXT_PUBLIC_NETWORK_PASSPHRASE (required) - NEXT_PUBLIC_FACTORY_CONTRACT_ID (required unless demo mode) - NEXT_PUBLIC_GOVERNOR_CONTRACT_ID (optional) - NEXT_PUBLIC_HORIZON_URL (optional) - NEXT_PUBLIC_SOROBAN_FEE_MULTIPLIER (optional, default 2) - NEXT_PUBLIC_DEMO_MODE (enables demo mode when set to 'true') Closes conduit-protocol#481
…ol#482) Updates CONTRIBUTING.md with comprehensive documentation for the @conduit-protocol/sdk monorepo dependency: - Explains that the SDK resolves to the streamFi-sdk git repo via tarball URL - Documents how to use a local SDK checkout for development - Explains lockfile implications for CI (git tarball vs local file paths) - Updated repository layout with new files (CopyableAddress, e2e tests, docs) Closes conduit-protocol#482
|
@SweetBoy-eth Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR resolves four issues related to UX improvements, testing infrastructure, documentation, and developer experience.
Closes #479 - Copy-to-clipboard feedback on addresses
Added a new
CopyableAddresscomponent that wraps truncated addresses with click-to-clipboard functionality:components/ui/CopyableAddress.tsxcopyToClipboardutility with HTTP fallbackConnectButton,StreamCard,OperatorInfo, stream detail page, transactions pageCloses #480 - Playwright: wallet-disconnect mid-load
Added Playwright E2E testing infrastructure:
playwright.config.ts,e2e/wallet-disconnect.spec.tstest:e2eandtest:e2e:uiscripts to package.json.gitignorefor Playwright artifactsCloses #481 - Environment variable reference
Created comprehensive documentation for all
NEXT_PUBLIC_*environment variables:docs/environment-variables.md.env.examplewithNEXT_PUBLIC_DEMO_MODECloses #482 - Contributing guide: monorepo SDK dependency
Updated
CONTRIBUTING.mdwith monorepo SDK documentation:@conduit-protocol/sdkresolves tostreamFi-sdkgit repoTesting
npm run typecheck- passesnpm run lint- passesnpm test- all 508 unit tests passFiles Changed
components/ui/CopyableAddress.tsx(new)components/ConnectButton.tsxcomponents/stream/StreamCard.tsxcomponents/stream/OperatorInfo.tsxapp/stream/[id]/page.tsxapp/transactions/page.tsxplaywright.config.ts(new)e2e/wallet-disconnect.spec.ts(new)docs/environment-variables.md(new).env.example.gitignoreCONTRIBUTING.mdpackage.jsonvitest.config.ts