test(streams): add contract schema validation and flags u32 round-trip for parseStreamInfo (closes #595) - #698
Open
martinss16kf wants to merge 1 commit into
Conversation
…seStreamInfo (closes conduit-protocol#595)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #595
Adds explicit schema tests against the on-chain Soroban contract's actual
StreamInfostructure (contracts/stream/src/storage.rs) to prevent model drift inparseStreamInfo. Specifically tests that flags are decoded strictly from theflags: u32bitmask and that standalone boolean fields are ignored.Key Changes
src/streams.ts:parseStreamInfoto enable direct unit testing and contract schema verification.parseStreamInfoto reliably handle bothscvSymbolandscvStringScVal key types.src/tests/parse-stream-info.test.ts:parseStreamInfo — contract schema validation and flags: u32 round-trip (#595).buildContractStreamInfoScValreflecting exact Soroban contract storage layout.StreamInfoScVal map round-trip.flags: u32).flags: u32bitmask flags (FLAG_PAUSED,FLAG_CANCELLED,FLAG_CLAWBACK_ENABLED) and higher bits.rate_per_secondandwithdrawn..toJSON().StreamsModule.get().Verification
npx vitest run src/tests/parse-stream-info.test.ts-> 13/13 passed (100%).npx vitest run-> 81/81 files passed (1028 passed, 0 failures).npx tsc --noEmit-> Clean (0 errors).