Admin client impl fixes#1823
Open
siobhan-sterrett wants to merge 4 commits intoconfluentinc:masterfrom
Open
Conversation
added 4 commits
September 26, 2024 13:29
…ype of TopicPartition
|
Siobhán Sterrett seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
1 similar comment
|
Siobhán Sterrett seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
|
I think this might touch some code I changed here But this project is not accepting PRs. It's annoying. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A handful of minor fixes to cimpl. Probably nothing that will impact real-life use-cases, since these are all buried inside
_AdminClientImpl, but they were bothering me."topic_names"and"future"inkwsarray inAdmin_describe_topics()If a user tried to pass
topic_namesorfutureinto_AdminClientImpl.describe_topics()as keyword arguments, they would end up swapped, which would lead to confusing errors.TypeErrorinAdmin_list_consumer_group_offset()ifrequestis not a listTypeErrorinAdmin_alter_consumer_group_offsets()ifrequestis not a listIn both of these cases, the library would raise
ValueErrorifrequestwas a list with anything other than 1 item... but ifrequestwasn't a list, it would result in an internal error when it tried to access its first item.plistinpy_to_c_parts()to be instances of a subtype ofTopicPartitionIf a user passed a list of instances of a subtype of
TopicPartition, the library would raise aTypeError, even if the instances were otherwise valid.