Open
Conversation
* Update topic prefix to include partition.assignment.strategy * Add test to check uniqueness after each rebalance * Add test to check all partitions are assigned after each rebalance * Extracted variable for repetitive code part
|
🎉 All Contributor License Agreements have been signed. Ready to merge. |
This comment has been minimized.
This comment has been minimized.
2 similar comments
This comment has been minimized.
This comment has been minimized.
Analysis Details3 Issues
Coverage and Duplications
Project ID: confluent-kafka-python |
MSeal
previously approved these changes
Sep 25, 2025
emasab
previously approved these changes
Sep 25, 2025
airlock-confluentinc
bot
force-pushed
the
dev_kip848_upgrade_downgrade_testing
branch
from
bf64b91 to
e81f784
Compare
Base automatically changed from
dev_kip848_upgrade_downgrade_testing
to
master
September 29, 2025 13:57
pranavrth
dismissed stale reviews from emasab and MSeal
The base branch was changed.
fangnx
reviewed
Oct 15, 2025
| number_of_partitions = 10 | ||
|
|
||
|
|
||
| def get_group_protocol_type(a, group_id): |
Member
There was a problem hiding this comment.
Are those changes (adding test) also intended for this PR (fixing typo)?
fangnx
reviewed
Oct 15, 2025
| return name | ||
|
|
||
| def create_topic_and_wait_propogation(self, prefix, conf=None, **create_topic_kwargs): | ||
| def delete_topic(self, topic): |
Member
There was a problem hiding this comment.
Same - it this intended to be added
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A typo fix. From 'propogation' to 'propagation'