Skip to content

Add oauth to supported auth options for WarpStream#3296

Merged
Noel Cothren (noeldevelops) merged 2 commits intomainfrom
ncothren/warpstream-oauth
Mar 2, 2026
Merged

Add oauth to supported auth options for WarpStream#3296
Noel Cothren (noeldevelops) merged 2 commits intomainfrom
ncothren/warpstream-oauth

Conversation

@noeldevelops
Copy link
Member

@noeldevelops Noel Cothren (noeldevelops) commented Feb 25, 2026

Summary of Changes

Click-testing instructions

  1. Try to Create, Edit, Export, Import a Direct Connection with WarpStream selected as the type.
  2. Expect SASL/OAUTHBEARER to be available in the Authentication Type dropdown, and expect that the credentials you enter are saved correctly and re-populated on import/edit. (note: it doesn't have to be a working connection to test the form behavior)

Optional: Any additional details or context that should be provided?

Screenshot 2026-02-25 at 8 22 55 AM

Pull request checklist

Please check if your PR fulfills the following (if applicable):

Tests

No new tests because we don't test every possible form combination. We already have playwright tests for the underlying components in the form to verify that the auth options components hold & pass inputs as expected.

Release notes

  • Does anything in this PR need to be mentioned in the user-facing CHANGELOG?

@sonarqube-confluent
Copy link

@noeldevelops
Copy link
Member Author

Stefan Sprenger (@flippingbits) tagging you to confirm, but I think we discussed that this doesn't need a change in ide-sidecar since it already fully supports OAuth for direct connections

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Enables SASL/OAUTHBEARER as an authentication option for WarpStream in the Direct Connections webview form, aligning the extension UI with WarpStream’s newly documented OAuth support.

Changes:

  • Allow "OAuth" in the filtered Kafka auth options when formConnectionType is "WarpStream".
  • Add an Unreleased changelog entry documenting the new supported auth option.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
src/webview/direct-connect-form.ts Expands WarpStream’s allowed Kafka auth dropdown options to include OAuth.
CHANGELOG.md Documents the new WarpStream OAuth support in the direct connections form.

Comment on lines +132 to +134
return allAuthOptions.filter((auth) =>
["None", "Basic", "SCRAM", "OAuth"].includes(auth.value),
);
Copy link

Copilot AI Feb 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change adds a new platform-specific auth option (OAuth) for WarpStream, but there’s no automated coverage asserting that the Kafka auth type dropdown includes "OAuth" when formConnectionType is "WarpStream" (and that switching platforms preserves/resets the selected auth type appropriately). Since this webview already has Playwright coverage for other auth/platform combinations, please add a spec that selects WarpStream and verifies the available kafka_cluster.auth_type options include OAuth (and that an invalid previous selection gets coerced to a valid one).

Copilot uses AI. Check for mistakes.
@noeldevelops Noel Cothren (noeldevelops) merged commit 430b0a2 into main Mar 2, 2026
18 checks passed
@noeldevelops Noel Cothren (noeldevelops) deleted the ncothren/warpstream-oauth branch March 2, 2026 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support OAuth for WarpStream connections

3 participants