Add oauth to supported auth options for WarpStream#3296
Add oauth to supported auth options for WarpStream#3296Noel Cothren (noeldevelops) merged 2 commits intomainfrom
Conversation
|
|
Stefan Sprenger (@flippingbits) tagging you to confirm, but I think we discussed that this doesn't need a change in |
There was a problem hiding this comment.
Pull request overview
Enables SASL/OAUTHBEARER as an authentication option for WarpStream in the Direct Connections webview form, aligning the extension UI with WarpStream’s newly documented OAuth support.
Changes:
- Allow
"OAuth"in the filtered Kafka auth options whenformConnectionTypeis"WarpStream". - Add an Unreleased changelog entry documenting the new supported auth option.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
src/webview/direct-connect-form.ts |
Expands WarpStream’s allowed Kafka auth dropdown options to include OAuth. |
CHANGELOG.md |
Documents the new WarpStream OAuth support in the direct connections form. |
| return allAuthOptions.filter((auth) => | ||
| ["None", "Basic", "SCRAM", "OAuth"].includes(auth.value), | ||
| ); |
There was a problem hiding this comment.
This change adds a new platform-specific auth option (OAuth) for WarpStream, but there’s no automated coverage asserting that the Kafka auth type dropdown includes "OAuth" when formConnectionType is "WarpStream" (and that switching platforms preserves/resets the selected auth type appropriately). Since this webview already has Playwright coverage for other auth/platform combinations, please add a spec that selects WarpStream and verifies the available kafka_cluster.auth_type options include OAuth (and that an invalid previous selection gets coerced to a valid one).




Summary of Changes
ide-sidecaralready fully supports OAuth for direct connections.Click-testing instructions
SASL/OAUTHBEARERto be available in the Authentication Type dropdown, and expect that the credentials you enter are saved correctly and re-populated on import/edit. (note: it doesn't have to be a working connection to test the form behavior)Optional: Any additional details or context that should be provided?
Pull request checklist
Please check if your PR fulfills the following (if applicable):
Tests
No new tests because we don't test every possible form combination. We already have playwright tests for the underlying components in the form to verify that the auth options components hold & pass inputs as expected.
Release notes