Skip to content

Follow sqlparser main to f3737877 - #212

Merged
LucaCappelletti94 merged 2 commits into
mainfrom
upstream/sqlite-colon-path-rejected
Oct 31, 2026
Merged

LucaCappelletti94 merged 2 commits into
mainfrom
upstream/sqlite-colon-path-rejected

Conversation

@LucaCappelletti94

@LucaCappelletti94 LucaCappelletti94 commented Oct 31, 2026 •

Copy link
Copy Markdown
Collaborator

Two sqlparser changes broke pg2sqlite against main, and each fix needs the other to build or pass, so they land together.

apache/datafusion-sqlparser-rs#2613 made SQLiteDialect reject Snowflake's val:key.key2 path, as SQLite does. One reverse-translation test still asserted that the dialect parses it. The behaviour it guards is unchanged and the reverse direction still refuses the path, now through the parser, so the test checks that sqlparser rejects it and that reverse_sql refuses it. The JsonAccess refusal stays, because ReverseTranslator takes any Expr.

apache/datafusion-sqlparser-rs#2743 parses namespaced storage parameters such as toast.autovacuum_enabled, so an option key is now an ObjectName. The security_invoker view check matches only a single-part key, so a namespaced toast.security_invoker is not read as one.

@LucaCappelletti94 LucaCappelletti94 added the dependencies Pull requests that update a dependency file label Oct 31, 2026
@LucaCappelletti94 LucaCappelletti94 changed the title Expect sqlparser to reject SQLite colon paths in the reverse test Follow sqlparser main to f3737877 Oct 31, 2026
@codecov

codecov Bot commented Oct 31, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@LucaCappelletti94
LucaCappelletti94 merged commit 5ca09a2 into main Oct 31, 2026
19 checks passed
@LucaCappelletti94
LucaCappelletti94 deleted the upstream/sqlite-colon-path-rejected branch November 1, 2026 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant