Repository navigation
Share the duplicated forward translator logic - #258
Merged
Merged
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| } | ||
|
|
||
| #[allow(clippy::too_many_lines)] | ||
| fn try_translate_distinct_on_query( |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
LucaCappelletti94
force-pushed
the
dedup/forward-translator
branch
from
November 6, 2026 08:11
4e709c3 to
3fd2b58
Compare
| } | ||
|
|
||
| #[allow(clippy::too_many_lines)] | ||
| fn try_translate_distinct_on_query( |
There was a problem hiding this comment.
pg2sqlite::impls::translator_impls::query::try_translate_distinct_on_query (function), signature changed, and tests/it/test_postgis_predicate_rewrite.rs:200:45, which this pull request leaves as it was, names it. Its text may need review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The forward translator built the same things in several places: the column scope of a statement's table, a plain table factor, a zeroed
CreateTable, the guard for a plain catalog function call, a function rebuilt under a new name, the literal field ofdate_truncanddate_part, the scale-preserving argument walk in both directions, the null-ignoringgreatestandleast, the query rewrite envelope, the conflict target lookup, and several refusal messages. Each is written once, and the refusal texts are unchanged.create_tableloses its two flags, which every caller set.Four tests pin refusals and the STRICT audit table, which nothing covered. They pass on main as well.