host: guard discoverd config setup in SetDefaultEnv to fix data race - #10
Merged
Conversation
SetDefaultEnv wrote discoverdClient and closed discoverdConfigured outside of the envMtx lock. If SetDefaultEnv were called concurrently with the DISCOVERD key, this could race on discoverdClient and, more critically, panic on a double close of the channel. Serialize the DISCOVERD handling under envMtx and track whether the channel has already been closed so it is only closed once.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SetDefaultEnv wrote discoverdClient and closed discoverdConfigured outside of the envMtx lock. If SetDefaultEnv were called concurrently with the DISCOVERD key, this could race on discoverdClient and, more critically, panic on a double close of the channel.
Serialize the DISCOVERD handling under envMtx and track whether the channel has already been closed so it is only closed once.