Proposed feature: Property key from String field value#61
Open
tingstad wants to merge 1 commit intoconstretto:masterfrom
tingstad:feature/prop_key_from_string_field_val
Open
Proposed feature: Property key from String field value#61tingstad wants to merge 1 commit intoconstretto:masterfrom tingstad:feature/prop_key_from_string_field_val
tingstad wants to merge 1 commit intoconstretto:masterfrom
tingstad:feature/prop_key_from_string_field_val
Conversation
Currently, field name is used as key when @configuration annotation has no value. A benefit of this is that the key is clearly visible everywhere the field is accessed. It cannot work, however, if the key consists of periods, like my.example.property=X Which is why I propose support for using field value as key expression. In most (?) IDEs, the key expression can then be viewed with Ctrl+mouseover or similar. This also means less duplication of key expressions. There are some disadvantages, like only working for String, which is why I won't be too sad if this feature request is not accepted :-)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, field name is used as key when @configuration annotation has no value.
A benefit of this is that the key is clearly visible everywhere the field is accessed.
It cannot work, however, if the key consists of periods, like my.example.property=X
Which is why I propose support for using field value as key expression.
In most (?) IDEs, the key expression can then be viewed with Ctrl+mouseover or similar.
This also means less duplication of key expressions.
There are some disadvantages, like only working for String, which is why I won't be too sad if this feature request is not accepted :-)