fix: fix load image failed#4888
Open
ningmingxiao wants to merge 1 commit into
Open
Conversation
ningmingxiao
force-pushed
the
fix_load
branch
2 times, most recently
from
8aadf5d to
680f950
Compare
ningmingxiao
force-pushed
the
fix_load
branch
5 times, most recently
from
75b7499 to
ad11fa6
Compare
Contributor
Author
|
after many tests I find TestLoadStdinFromPipe still failed sometimes because of the tag size( it should be containerd bug? ) and another err log is (with shot tag see ningmingxiao#14 ci logs) |
ningmingxiao
force-pushed
the
fix_load
branch
3 times, most recently
from
40c9f0d to
703400e
Compare
Member
Isn't the tag length deterministic? |
Contributor
Author
|
now tag length will not generate error now but find anoter error after many times test |
ningmingxiao
force-pushed
the
fix_load
branch
2 times, most recently
from
65de54a to
dc3acf6
Compare
ChengyuZhu6
reviewed
May 12, 2026
| return progressFn, done | ||
| } | ||
|
|
||
| func ProgressHandlerLoadImage(ctx context.Context, client *containerd.Client, beforeSet map[string]bool, options types.ImageLoadOptions) (transfer.ProgressFunc, func(), *[]images.Image) { |
Member
There was a problem hiding this comment.
When client.Transfer finishes, it triggers cancel(), immediately killing the ProgressHandlerLoadImage goroutine. Any delayed saved events will still be dropped?
|
|
||
| var loadedImages []images.Image | ||
| pf, done := transferutil.ProgressHandler(ctx, options.Stdout) | ||
| storeOpts = append(storeOpts, transferimage.WithNamedPrefix(fmt.Sprintf("import-%s", time.Now().Format("2006-01-02")), true)) |
Member
There was a problem hiding this comment.
It fixes the dash-to-space bug, but untagged archives will now print internal names to users?
Signed-off-by: ningmingxiao <ning.mingxiao@zte.com.cn>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix test TestLoadStdinFromPipe failed
reproduce
add some sleep at https://github.com/containerd/nerdctl/blob/v2.3.0/pkg/imgutil/load/load.go#L93
nothing will out put
@ChengyuZhu6 it's introduce by commit c40fda5
another reason containerd/containerd#13097
so we can't use identifier := data.Identifier() now until containerd fix it.