save: add --quiet/-q to suppress progress output#5054
Conversation
|
Please squash the commits |
s3onghyun
force-pushed
the
save-quiet-flag
branch
from
0f4d252 to
da8c9c5
Compare
|
Done, squashed into a single commit. Also excluded |
| }, | ||
| Expected: func(data test.Data, _ test.Helpers) *test.Expected { | ||
| return &test.Expected{ | ||
| ExitCode: 0, |
There was a problem hiding this comment.
can use Tigron frameworks exit codes
`nerdctl save` always writes a progress bar to stderr, which clutters logs when it is used in scripts and CI. Add a `--quiet`/`-q` flag that routes the transfer progress to io.Discard, mirroring the existing `--quiet` flag on `nerdctl load`. The archive is still written normally; only the progress output is suppressed. --quiet is a nerdctl-specific flag that docker save does not have, so the new TestSaveQuiet is excluded from the Docker compatibility test mode. Closes containerd#4958 Signed-off-by: s3onghyun <s3onghyun@users.noreply.github.com>
s3onghyun
force-pushed
the
save-quiet-flag
branch
from
da8c9c5 to
5c98de1
Compare
|
Thanks @sathiraumesh — updated to use |
|
The PR seems accidentally closed? |
|
Sorry about that @AkihiroSuda — it looks like my force-push (after squashing / applying @sathiraumesh's suggestion) accidentally closed it. The branch |
|
Please open a fresh PR |
|
Reopened as #5064 (fresh branch on top of current |
3 participants
Fixes #4958.
nerdctl savealways writes a progress bar to stderr, which clutters logs when it is used in scripts and CI. This adds a--quiet/-qflag that suppresses the progress output.The implementation mirrors the existing
--quietflag onnerdctl load: the flag is threaded intoImageSaveOptions.Quiet, and when set, the transfer progress handler writes toio.Discardinstead ofos.Stderr. The archive itself is written exactly as before; only the progress output is suppressed.cmd/nerdctl/image/image_save.go: register-q, --quietand pass it into the optionspkg/api/types/image_types.go: addQuiettoImageSaveOptionspkg/cmd/image/save.go: route progress toio.Discardwhen quietdocs/command-reference.md: document the flagcmd/nerdctl/image/image_save_test.go: addTestSaveQuietverifying the archive is still produced correctly with--quietManual check:
nerdctl save --helpnow lists-q, --quiet Suppress the progress output.