test: refactor container_run_cgroup_linux_test.go to use Tigron#5070
Open
papidb wants to merge 1 commit into
Open
test: refactor container_run_cgroup_linux_test.go to use Tigron#5070papidb wants to merge 1 commit into
papidb wants to merge 1 commit into
Conversation
papidb
force-pushed
the
test/refactor-container-run-cgroup-linux-test-to-tigron
branch
from
July 15, 2026 08:10
27aa011 to
1d639f9
Compare
46 tasks
AkihiroSuda
reviewed
Jul 17, 2026
Member
|
Marking the PR as a draft as the CI is failing. Please click |
AkihiroSuda
marked this pull request as draft
July 17, 2026 10:41
papidb
marked this pull request as ready for review
July 18, 2026 10:58
AkihiroSuda
reviewed
Jul 18, 2026
| addr := defaults.DefaultAddress | ||
| if rootlessutil.IsRootless() { | ||
| xdr, err := rootlessutil.XDGRuntimeDir() | ||
| if err != nil { |
Contributor
Author
There was a problem hiding this comment.
Fair, will implement.
AkihiroSuda
reviewed
Jul 18, 2026
Contributor
Author
There was a problem hiding this comment.
After I attend to the rootless comments, I will then squash the commits
AkihiroSuda
reviewed
Jul 18, 2026
| if err != nil { | ||
| xdr = fmt.Sprintf("/run/user/%d", os.Geteuid()) | ||
| } | ||
| pidFile := filepath.Join(xdr, "containerd-rootless", "child_pid") |
Member
There was a problem hiding this comment.
use
nerdctl/pkg/rootlessutil/parent_linux.go
Line 54 in 31641bd
AkihiroSuda
reviewed
Jul 18, 2026
| cid := strings.TrimSpace(stdout) | ||
| addr := defaults.DefaultAddress | ||
| if rootlessutil.IsRootless() { | ||
| xdr, err := rootlessutil.XDGRuntimeDir() |
Member
There was a problem hiding this comment.
use
nerdctl/pkg/rootlessutil/parent_linux.go
Line 38 in 31641bd
Signed-off-by: Daniel Benjamin <benjamindaniel706@gmail.com>
papidb
force-pushed
the
test/refactor-container-run-cgroup-linux-test-to-tigron
branch
from
July 19, 2026 00:41
e9cba40 to
19b7895
Compare
AkihiroSuda
reviewed
Jul 19, 2026
| if cgroups.Mode() != cgroups.Unified { | ||
| t.Skip("test requires cgroup v2") | ||
| } | ||
| testutil.DockerIncompatible(t) // Docker lacks --cgroup-conf |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rewrite tests in container_cp_linux_test.go from testutil.NewBase to nerdtest.Setup (Tigron framework). Part of #4613.