test: refactor container_run_linux_test.go to use Tigron#5071
Merged
AkihiroSuda merged 1 commit intoJul 19, 2026
Merged
Conversation
46 tasks
Member
|
Marking as a draft, as CI including lint is failing. |
AkihiroSuda
marked this pull request as draft
July 17, 2026 10:14
papidb
force-pushed
the
test/refactor-container-run-linux-test-to-tigron
branch
from
July 17, 2026 21:05
a46f144 to
5fda100
Compare
papidb
marked this pull request as ready for review
July 18, 2026 10:58
AkihiroSuda
requested changes
Jul 18, 2026
AkihiroSuda
left a comment
AkihiroSuda
left a comment
Member
There was a problem hiding this comment.
Please squash the commits
AkihiroSuda
reviewed
Jul 18, 2026
|
|
||
| // Was thinking of os.ReadLink("/proc/1/ns/uts") | ||
| // but you'd get EPERM for rootless. Just validate the | ||
| // hostname is the same. |
Member
There was a problem hiding this comment.
The comment strings should be preserved
AkihiroSuda
reviewed
Jul 18, 2026
| } | ||
|
|
||
| func TestRunAddHost(t *testing.T) { | ||
| // Not parallelizable (https://github.com/containerd/nerdctl/issues/1127) |
AkihiroSuda
reviewed
Jul 18, 2026
| Description: "stty with -it", | ||
| Cleanup: func(data test.Data, helpers test.Helpers) { | ||
| helpers.Ensure("rm", "-f", data.Identifier()) | ||
| helpers.Anyhow("rm", "-f", data.Identifier()) |
AkihiroSuda
reviewed
Jul 18, 2026
|
|
||
| func TestRunDeviceCDI(t *testing.T) { | ||
| t.Parallel() | ||
| // Although CDI injection is supported by Docker, specifying the --cdi-spec-dirs on the command line is not. |
AkihiroSuda
reviewed
Jul 18, 2026
|
|
||
| func TestRunDeviceCDIWithNerdctlConfig(t *testing.T) { | ||
| t.Parallel() | ||
| // Although CDI injection is supported by Docker, specifying the --cdi-spec-dirs on the command line is not. |
AkihiroSuda
reviewed
Jul 18, 2026
| // TestRunGPU tests GPU injection using the --gpus flag. | ||
| func TestRunGPU(t *testing.T) { | ||
| t.Parallel() | ||
| // Although CDI injection is supported by Docker, specifying the --cdi-spec-dirs on the command line is not. |
AkihiroSuda
reviewed
Jul 18, 2026
| // TestRunGPUWithOtherCDIDevices tests GPU CDI injection along with other CDI devices. | ||
| func TestRunGPUWithOtherCDIDevices(t *testing.T) { | ||
| t.Parallel() | ||
| // Although CDI injection is supported by Docker, specifying the --cdi-spec-dirs on the command line is not. |
AkihiroSuda
reviewed
Jul 18, 2026
| return subTests | ||
| } | ||
|
|
||
| func assertAddHostEntry(stdout, expected string) error { |
Member
There was a problem hiding this comment.
Needs a comment to explain what it does
AkihiroSuda
reviewed
Jul 18, 2026
| return nil | ||
| } | ||
|
|
||
| func assertAddHostEntries(stdout string, expected []string) error { |
Member
There was a problem hiding this comment.
Same. How is this different from assertAddHostEntry?
Contributor
Author
There was a problem hiding this comment.
there's none, I've deleted assertAddHostEntry in favor of assertAddHostEntries.
Contributor
Author
There was a problem hiding this comment.
I also added comments to assertAddHostEntries
papidb
force-pushed
the
test/refactor-container-run-linux-test-to-tigron
branch
from
July 18, 2026 22:23
bca2734 to
d635153
Compare
AkihiroSuda
reviewed
Jul 18, 2026
|
|
||
| func TestRunDeviceCDI(t *testing.T) { | ||
| t.Parallel() | ||
| // Although CDI injection is supported by Docker, specifying the --cdi-spec-dirs on the command line is not. |
Member
There was a problem hiding this comment.
This should be commented around the line of require.Not(nerdtest.Docker).
Same for other tests too.
Contributor
Author
There was a problem hiding this comment.
If I understand you correctly, you're asking me to move the // Although CDI injection is supported by Docker... comment to sit above the testCase.Require = require.Not(nerdtest.Docker) line, yes?
papidb
force-pushed
the
test/refactor-container-run-linux-test-to-tigron
branch
2 times, most recently
from
July 18, 2026 23:34
cf13079 to
656035d
Compare
Signed-off-by: Daniel Benjamin <benjamindaniel706@gmail.com>
papidb
force-pushed
the
test/refactor-container-run-linux-test-to-tigron
branch
from
July 18, 2026 23:38
656035d to
d4f4231
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rewrite tests in container_run_linux_test.go from testutil.NewBase to nerdtest.Setup (Tigron framework). Part of #4613.