Honor context deadline in send operations to prevent indefinite hangs#227
Open
novahe wants to merge 1 commit intocontainerd:mainfrom
Open
Honor context deadline in send operations to prevent indefinite hangs#227novahe wants to merge 1 commit intocontainerd:mainfrom
novahe wants to merge 1 commit intocontainerd:mainfrom
Conversation
653b2cf to
a881bb0
Compare
Signed-off-by: novahe <heqianfly@gmail.com>
a881bb0 to
786257d
Compare
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
fix #174
where ttrpc client
sendoperations (Write/Flush) could hang indefinitely if the peer stopped reading, even when the request context had expired.Changes
Channel.send,Client.send,serverConn.run, andstream.sendto accept and propagatecontext.Context.net.Conn.SetWriteDeadlineinchannel.sendbased on the context's deadline.channel.sendto support manual context cancellation (ctx.Done()), ensuring thatcontext.WithCancelalso interrupts blocked I/O.failSendto ensure that any write-side failure (including timeouts and cancellations) results in closing the underlying connection. This prevents protocol corruption due to partialbufiowrites.mapWriteTimeoutto correctly translate I/O timeout errors intocontext.DeadlineExceededorcontext.Canceled.createStreamWithContextto ensure that streams are properly removed from the client's internal map if the initial send fails.