profile.d/toolbox.sh: set PS1 as explicit string constants#1514
profile.d/toolbox.sh: set PS1 as explicit string constants#1514juhp wants to merge 1 commit intocontainers:mainfrom
Conversation
since they are constants there is no need to use printf and embed binary color codes, which also made it hard to match on toolbox PS1. Signed-off-by: Jens Petersen <petersen@redhat.com> containers#1514
|
Build failed. ❌ unit-test FAILURE in 6m 05s |
since it is constant there is no need to use printf and embed binary color codes, which also made it hard to match on toolbox PS1. Signed-off-by: Jens Petersen <petersen@redhat.com> containers#1514
|
(I dropped the zsh PS1 change, since shellcheck doesn't like |
|
Build succeeded. ✔️ unit-test SUCCESS in 5m 34s |
|
Closing this for now in favor of #1517 |
|
Merge Failed. This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset. |
1 participant
Since the PS1 strings are constants there is no need to use printf and
embed binary color codes, which also makes it hard to match on toolbox PS1.
I tested these in bash and zsh locally and they seem to work fine.