-
Notifications
You must be signed in to change notification settings - Fork 241
[release-0.0.99.5] build: Bump github.com/sirupsen/logrus to 1.9.3 #1738
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-0.0.99.5] build: Bump github.com/sirupsen/logrus to 1.9.3 #1738
Conversation
|
Merge Failed. This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset. |
Summary of ChangesHello @debarshiray, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request performs a crucial dependency upgrade for the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request correctly bumps the github.com/sirupsen/logrus dependency to version 1.9.3, which mitigates the security vulnerability GHSA-4f99-4q7p-p3gh. The changes in src/go.mod and src/go.sum are correct and reflect the dependency update and the execution of go mod tidy. The changes are sound and address the intended purpose of the pull request.
... for CVE-2025-65637 or GHSA-4f99-4q7p-p3gh. The src/go.sum file was updated with 'go mod tidy'. containers#1503 containers#1738 https://github.com/containers/toolbox/security/dependabot/26 (cherry picked from commit efa8da9)
ee2b964 to
41b71bc
Compare
... for CVE-2025-65637 or GHSA-4f99-4q7p-p3gh. The src/go.sum file was updated with 'go mod tidy'. containers#1503 containers#1738 https://github.com/containers/toolbox/security/dependabot/26 (cherry picked from commit 3de56c0)
|
Hey @TristanCacqueray @morucci @nhicher ! Just now I created a new branch called I thought adding job.branches attributes will do the trick; so, I added them in this PR; but it didn't make any difference. Any idea about what might be missing? |
|
Hey @debarshiray, perhaps the branch is not protected? In the config, toolbox CI excludes unprotected branch, see: https://softwarefactory-project.io/cgit/config/tree/resources/toolbox.yaml |
95bcee1 to
cda60e3
Compare
95bcee1 to
8c8f9f4
Compare
Thanks for the hint - it did the trick! |
|
Build failed. ❌ unit-test FAILURE in 1m 38s |
8c8f9f4 to
9341a89
Compare
... for CVE-2025-65637 or GHSA-4f99-4q7p-p3gh. The src/go.sum file was updated with 'go mod tidy'. containers#1503 containers#1738 https://github.com/containers/toolbox/security/dependabot/26 (cherry picked from commit efa8da9)
... for CVE-2025-65637 or GHSA-4f99-4q7p-p3gh. The src/go.sum file was updated with 'go mod tidy'. containers#1503 containers#1738 https://github.com/containers/toolbox/security/dependabot/26 (cherry picked from commit 3de56c0)
4ccc2ff to
96561b3
Compare
... for CVE-2025-65637 or GHSA-4f99-4q7p-p3gh. The src/go.sum file was updated with 'go mod tidy'. containers#1503 containers#1738 https://github.com/containers/toolbox/security/dependabot/26 (cherry picked from commit efa8da9)
|
Build succeeded. ✔️ unit-test SUCCESS in 1m 42s |
... for CVE-2025-65637 or GHSA-4f99-4q7p-p3gh. The src/go.sum file was updated with 'go mod tidy'. containers#1503 containers#1738 https://github.com/containers/toolbox/security/dependabot/26 (cherry picked from commit 3de56c0)
|
Build succeeded. ✔️ unit-test SUCCESS in 1m 39s |
... for CVE-2025-65637 or GHSA-4f99-4q7p-p3gh. The src/go.sum file was updated with 'go mod tidy'. containers#1503 containers#1738 https://github.com/containers/toolbox/security/dependabot/26 (cherry picked from commit efa8da9) (cherry picked from commit 90f3bf281ee743e296da1332b4649fed85e1e579)
... for CVE-2025-65637 or GHSA-4f99-4q7p-p3gh. The src/go.sum file was updated with 'go mod tidy'. containers#1503 containers#1738 https://github.com/containers/toolbox/security/dependabot/26 (cherry picked from commit 3de56c0) (cherry picked from commit 67e469515d2dbcb8538755a538b40695b52d40e6)
4cd5fb5 to
b307bd9
Compare
... for CVE-2025-65637 or GHSA-4f99-4q7p-p3gh. The src/go.sum file was updated with 'go mod tidy'. containers#1503 containers#1738 https://github.com/containers/toolbox/security/dependabot/26 (cherry picked from commit efa8da9)
|
Build succeeded. ✔️ unit-test SUCCESS in 1m 45s |
... for CVE-2025-65637 or GHSA-4f99-4q7p-p3gh. The src/go.sum file was updated with 'go mod tidy'. containers#1503 containers#1738 https://github.com/containers/toolbox/security/dependabot/26 (cherry picked from commit efa8da9)
... for CVE-2025-65637 or GHSA-4f99-4q7p-p3gh. The src/go.sum file was updated with 'go mod tidy'. containers#1503 containers#1738 https://github.com/containers/toolbox/security/dependabot/26 (cherry picked from commit 3de56c0)
b307bd9 to
139447e
Compare
|
Build succeeded. ✔️ unit-test SUCCESS in 2m 14s |
|
Build succeeded. ✔️ unit-test SUCCESS in 1m 42s |
... for CVE-2025-65637 or GHSA-4f99-4q7p-p3gh.
The src/go.sum file was updated with
go mod tidy.#1503
https://github.com/containers/toolbox/security/dependabot/26
(cherry picked from commits 3de56c0 and efa8da9)