[release-0.0.99.5] Prepare stable branch (part 8) #1749
Conversation
Fedora 40 reached End of Life on 13th May 2025: https://docs.fedoraproject.org/en-US/releases/eol/ containers#1650 containers#1748 (backported from commit 7cfe9a7)
containers#1730 containers#1748 (backported from commit 431f7f0)
Fedora 41 reached End of Life on 15th December 2025: https://docs.fedoraproject.org/en-US/releases/eol/ containers#1733 containers#1748 (backported from commit 36605d8)
debarshiray
requested review from
Foxboron,
Jmennius and
olivergs
as code owners
|
Merge Failed. This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset. |
Red Hat Enterprise Linux 8.7 reached End of Life on 31st May 2023: https://access.redhat.com/articles/4038291 https://access.redhat.com/support/policy/updates/errata Since the tests are intended for Toolbx, not the Red Hat infrastructure, it will be better to use a newer image, because it will be closer to what the users are seeing. containers#1437 containers#1749 (backported from commit dcec568)
Summary of ChangesHello @debarshiray, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request is part of the ongoing effort to prepare the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Ignored Files
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
debarshiray
force-pushed
the
wip/rishi/prepare-release-0.0.99.5-part-8
branch
from
bf3816b to
b096fb2
Compare
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request prepares the release-0.0.99.5 branch. The changes include updating the Zuul CI configuration to run on this new branch, bumping the tested Fedora versions, and updating RHEL tests from version 8.7 to 8.9. The changes look good overall. I've added a few suggestions to improve maintainability by reducing hardcoded values in the CI configuration and test files, which should make future release preparations easier.
I am having trouble creating individual review comments. Click here to see my feedback.
.zuul.yaml (20)
To improve maintainability and reduce repetition, you could define the branch name release-0.0.99.5 once using a YAML anchor and then reuse it for all jobs. This will make it easier to update the branch for future releases.
For example, you can define an anchor here:
branches: &release_branch release-0.0.99.5And then reuse it in other jobs with *release_branch:
- job:
name: unit-test-migration-path-for-coreos-toolbox
branches: *release_branch
... branches: &release_branch release-0.0.99.5test/system/101-create.bats (142-154)
To improve maintainability and avoid repeating the version number, consider using a local variable for the RHEL version. This makes it easier to update the version in the future.
@test "create: RHEL 8.9" {
local rhel_version="8.9"
pull_distro_image rhel "$rhel_version"
run "$TOOLBOX" --assumeyes create --distro rhel --release "$rhel_version"
assert_success
assert_output --partial "Created container: rhel-toolbox-$rhel_version"
assert_output --partial "Enter with: toolbox enter rhel-toolbox-$rhel_version"
run podman ps -a
assert_output --regexp "Created[[:blank:]]+rhel-toolbox-$rhel_version"
}
test/system/104-run.bats (94-97)
Similar to other test files, using a variable for the RHEL version would improve maintainability.
@test "run: Smoke test with RHEL 8.9" {
local rhel_version="8.9"
create_distro_container rhel "$rhel_version" "rhel-toolbox-$rhel_version"
run --separate-stderr "$TOOLBOX" run --distro rhel --release "$rhel_version" true
test/system/setup_suite.bash (48)
The RHEL version is hardcoded here and in several other test files (102-list.bats, 203-network.bats, 206-user.bats, etc.). To improve maintainability, consider defining distribution versions as readonly variables at the top of a shared helper file or at the top of each test file. This would centralize the version numbers and make future updates much easier and less error-prone.
Red Hat Enterprise Linux 8.9 reached End of Life when RHEL 8.10 was released on 22nd May 2024: https://access.redhat.com/articles/3078 https://access.redhat.com/support/policy/updates/errata For what it's worth, RHEL 8's full support phase ended on the 31st of May 2024 and it wil be in maintenance support, as RHEL 8.10, until the corresponding day in 2029. containers#1522 containers#1749 (backported from commit 18d47d1)
The GitHub Actions workflows for building and publishing the images were removed because the image definitions were removed from this branch [1]. [1] Commit f2b2a18 containers@f2b2a18ddef288a3 containers#1739 containers#1749
|
Build succeeded. ✔️ unit-test SUCCESS in 1m 43s |
|
Build succeeded. ✔️ unit-test SUCCESS in 1m 44s |
|
Build succeeded. ✔️ unit-test SUCCESS in 1m 38s |
1 participant
... for CVE-2025-65637 or GHSA-4f99-4q7p-p3gh.
https://github.com/containers/toolbox/security/dependabot/26