Conversation
…cell Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013L98ArhvRJ1p7riCvTRXBf
A disconnected has-one still exposes a placeholder id, so the cell wrapper's `if (!id)` guard never triggered on an empty relation. The cell offered include/exclude, and either action filtered on `__placeholder_…`, which the server rejects as an invalid id. Wrap the cell only when the related id is a persisted one. An empty value stays filterable through the column's null filter. Fixes #136 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013L98ArhvRJ1p7riCvTRXBf
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #136
Problem
DataGridHasOneColumnwraps every cell in the include/exclude filter tooltip when the related handle has anid. A disconnected has-one still returns a placeholder id (__placeholder_…), so an empty cell got the tooltip too. „Filter" or „Exclude" there stored the placeholder id in the filter artifact, and the server rejected the resulting{ id: { eq: "__placeholder_…" } }condition as an invalid id.Change
has-one-column.tsx: wrap the cell only when the related id is a persisted id (isPersistedId). An empty relation, and a temporary id, render the plain cell content.has-many-column.tsxis not changed: a has-many handle has noid, so its wrapper already returns the plain content.Tests
tests/react/dataview/hasOneColumnEmptyCellFilter.test.tsx: a grid with one connected and one empty author. The connected cell has the tooltip trigger; the empty cell has none. It fails onmain(commitc741fad) and passes with the fix.bun run typecheckandbun run test(2199 pass) pass locally. The browser suite was not run locally.🤖 Generated with Claude Code
https://claude.ai/code/session_013L98ArhvRJ1p7riCvTRXBf